connectd: fix double-free crash on connection timeout. #7736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpctx may not get cleaned immediately, so the timeout (a child of the struct early_peer at this point) can still outlast the conn. Do the clearer thing, and explicitly free the timeout. Changelog-Fixed: connectd: crash on erroneous timeout. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
fix-connectd-timeout-crash
branch
from
d215ecc to
a3ba33e
Compare
vincenzopalazzo
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
ACK a3ba33e
Would be good to have the stacktrace inside the commit message for next time :) but I know that you know, you tech me that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tmpctx may not get cleaned immediately, so the timeout (a child of the struct early_peer at this point) can still outlast the conn!
Changelog-Fixed: connectd: crash on erroneous timeout.
Fixes: #7728