topology: call listpeerchannels_done directly #7704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JssDWt
force-pushed
the
jssdwt-skip-listpeerchannels-in-listchannels
branch
from
9f32642 to
2a2fe63
Compare
|
Updated to include the fix in bfe0557 |
|
I don't think this CI failure is related to this PR: https://github.com/ElementsProject/lightning/actions/runs/11121240025/job/30901106930?pr=7704 |
|
@ShahanaFarooqui @cdecker can we prioritize this? |
When cln is run without deprecated apis, the `listchannels` call would still query `listpeerchannels`, even though it wouldn't use the result. This adds unnecessary time to the call. Especially in case the node has many channels. This commit skips the listpeerchannels call in case the outcome won't be used. Changelog-Fixed: Improve listchannels performance
cdecker
force-pushed
the
jssdwt-skip-listpeerchannels-in-listchannels
branch
from
2a2fe63 to
38efb9d
Compare
|
ACK 2a2fe63 |
|
@cdecker should it be marked for point release or 24.11? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cln is run without deprecated apis, the
listchannelscall would still querylistpeerchannels, even though it wouldn't use the result. This adds unnecessary time to the call. Especially in case the node has many channels. This commit skips the listpeerchannels call in case the outcome won't be used.Changelog-Fixed: Improve listchannels performance
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked: