trace payment_continue and payment mods #7556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @JssDWt, I've been wanting to instrument this part of the code for quite a while, and never had the muse to get started. I added #7575 on top of your change to instrument all JSON-RPC calls that plugins start, and we can likely also instrument all entrypoints to the plugin as well (rpcmethod, hook and notifications). |
JssDWt
force-pushed
the
jssdwt-payment-trace-attempt-2
branch
from
dd941ac to
c25f23e
Compare
cdecker
requested changes
Aug 16, 2024
The `send_outreq` function is a good place to suspend and resume traces, since these are usually the places where we hand off control back to the `io_loop`. This assumes that we do not continue doing heavy liftin after we have queued an `outreq` call, but that is most likely the case anyway. This frees us from having to track suspensions whenever we call the RPC from a plugin.
JssDWt
force-pushed
the
jssdwt-payment-trace-attempt-2
branch
from
c25f23e to
e0ce284
Compare
|
Rebased. And also fixed a bug where the |
|
Pretty! I missed this on the milestone, fixed now. Rebasing now. |
|
This is confusing. #7575 says it builds on this, this says it's now based on that. And I can't force push to this branch to rebase. So I'm going to add to the confusion by opening another PR! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.