Gossmap crash fix #7330
Merged
Gossmap crash fix #7330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
suggested changes
May 23, 2024
There was a problem hiding this comment.
Is it possible that we have another crash for the gossip map? e.g: #7320
BTW except of the grpc python files we are good to go for me
…nt messages. We only write these in two places: one where we get a message from lightningd about our own channel, and one where we get a reply from lightningd about a txout check. The former case we explicitly check that we don't already have it in gossmap, so add checks to the latter case, and give verbose detail if it's found. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This seems to be happening to some people, so don't panic. Unfortunately we don't have a good error callback here, so msg to stderr. Fixes: ElementsProject#7249 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
endothermicdev
force-pushed
the
guilt/gossmap-crash
branch
from
293d1b5 to
6736f6e
Compare
|
Looks reasonable - I hope we get some more insight from this. Removed the protobuf diff that was failing check-gen-updated. |
vincenzopalazzo
merged commit 6b91497
into
ElementsProject:master
34 of 35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7249
Can't see how this is happening on a fresh gossip store, but avoid crashing if it does, and put in more sanity checks in the only place I can see that we might do this.