pyln: Add a dynamic configs and a callback for changes #7289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
force-pushed
the
202405-pyln-setconfig-condition
branch
from
3a54f18 to
c10e1a9
Compare
|
I'd love feedback from @rustyrussell and @CGuida on this since it is an alternative to #7288 |
cdecker
force-pushed
the
202405-pyln-setconfig-condition
branch
from
a80ef6c to
e23bc63
Compare
rustyrussell
force-pushed
the
202405-pyln-setconfig-condition
branch
from
e23bc63 to
d7ea1c7
Compare
|
Fixed commit message on "fix..." commit. |
rustyrussell
force-pushed
the
202405-pyln-setconfig-condition
branch
from
d7ea1c7 to
0df80c6
Compare
|
Fixed 'default: null' which cln doesn't like on flag values (if you specify a default, it must be false). |
cdecker
force-pushed
the
202405-pyln-setconfig-condition
branch
from
0df80c6 to
6cc8d43
Compare
rustyrussell
force-pushed
the
202405-pyln-setconfig-condition
branch
from
6cc8d43 to
2b76ae3
Compare
|
Trivial rebase on master to re-run tests, and move one part of commit to make flake8 happy with each commit. Ack 2b76ae3 |
We didn't actually *change* the value you'd see, when we got a setconfig call! Changelog-Added: pyln-client: implement setconfig hook for plugins so you can see changes in `dynamic` options. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
I was looking into using the `threading.Condition` but since we're already rather heavily using callbacks, this allows us to stay single-threaded, and not having to completely hook the `setconfig` function. Changelog-Added: pyln-client: Added a notification mechanism for config changes
And don't set the value unless it passes. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
202405-pyln-setconfig-condition
branch
from
2b76ae3 to
7f1226c
Compare
|
Oh, we broke our own plugins which use plugin.option['optname']['value'] instead of get_value like I guess they're supposed to. Fix that so we don't break other plugins! |
[ Fix not to include 'value' and 'default' (if None) in getmanifest response --RR ] [ Fix to support [] operator for existing plugins (including our test ones!) --RR ]
Noticed as I was debugging. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
202405-pyln-setconfig-condition
branch
from
7f1226c to
fa8b6aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #7288, that uses a callback per config
option rather than hooking the
setconfigfunction entirely. Thisallows us to react to individual config options changing, while still
maintaining the default
setconfigbehavior.