Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging: add TRACE log level and move some DEBUG logging to it #7280

Merged
merged 5 commits into from
May 9, 2024
Merged

logging: add TRACE log level and move some DEBUG logging to it #7280

merged 5 commits into from
May 9, 2024

Commits on Apr 27, 2024

  1. logging: add TRACE between DEBUG and IO 

    By moving super-noisy debugging logging to new TRACE level we can
make long-term logging at DEBUG possible w/o removing any logging.

Addresses ([ElementsProject#7279])

Related Issues:
ElementsProject#6927
chrisguida/smaug#34
ZmnSCPxj/clboss#194
    @ksedgwic
    ksedgwic committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    63305a9 View commit details
    Browse the repository at this point in the history

  2. logging: move two noisy plugin_hook logging entries to TRACE 

    These are very noisy at the debug level:
DEBUG   lightningd: Calling rpc_command hook of plugin clboss
DEBUG   lightningd: Plugin clboss returned from rpc_command hook call

As seen in ZmnSCPxj/clboss#194
    @ksedgwic
    ksedgwic committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    7de3eab View commit details
    Browse the repository at this point in the history

  3. logging: move noisy gossip recv message to TRACE 

    ```
lightningd-test   | 2024-04-26T13:07:01.581Z DEBUG   031c64a68e6d1b9e50711336d92b434c584ce668b2fae59ee688bd73713fee1569-gossipd: handle_recv_gossip: WIRE_CHANNEL_UPDATE
lightningd-test   | 2024-04-26T13:07:01.581Z DEBUG   031c64a68e6d1b9e50711336d92b434c584ce668b2fae59ee688bd73713fee1569-gossipd: handle_recv_gossip: WIRE_CHANNEL_UPDATE
lightningd-test   | 2024-04-26T13:07:01.582Z DEBUG   031c64a68e6d1b9e50711336d92b434c584ce668b2fae59ee688bd73713fee1569-gossipd: handle_recv_gossip: WIRE_CHANNEL_UPDATE
```
    @ksedgwic
    ksedgwic committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    8917d41 View commit details
    Browse the repository at this point in the history

  4. drive-by: fix valgrind complaint about uninitialized memory

    @ksedgwic
    ksedgwic committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    29f5026 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Add missing docs and Changelog-Added line. 

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Added: Config: new log level `trace` where we moved the very noisiest `debug` logs.
    @rustyrussell @ksedgwic
    rustyrussell authored and ksedgwic committed May 7, 2024
    Configuration menu
    Copy the full SHA
    5905afd View commit details
    Browse the repository at this point in the history