Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pay listpeerchannels fix #7235

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Pay listpeerchannels fix #7235

merged 2 commits into from
Apr 30, 2024

Commits on Apr 20, 2024

  1. pytest: test pay during channel open 

    Notably this parses the listpeerchannels output while the state is
still uncommitted, i.e., state = OPENINGD.
    @endothermicdev
    endothermicdev committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    688408c View commit details
    Browse the repository at this point in the history

  2. pay: ignore uncommited channels in listpeerchannels output 

    Uncommited channels are missing several fields which would normally be
populated by an active channel.  This simply skips them for the purposes
of finding a route.  The particular culprit was:
{
  "peer_id": "038cd9f3679d5b39bb2105978467918d549572de472f07dd729e37c7a6377d41d5",
  "peer_connected": true,
  "state": "OPENINGD",
  "owner": "lightning_openingd",
  "opener": "local",
  "to_us_msat": 8317559000,
  "total_msat": 8317559000,
  "features": [
    "option_static_remotekey",
    "option_anchors_zero_fee_htlc_tx"
  ]
}

Fixes ElementsProject#7197 - SEGV in direct_pay_listpeerchannels when field private missing

Changelog-Fixed: Fixed crash in pay plugin caused by parsing uncommitted dual open channels
    @endothermicdev
    endothermicdev committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    2dae71d View commit details
    Browse the repository at this point in the history