Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msggen: add low level fundchannel methods #7231

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

daywalker90
Copy link
Contributor

Based on: #7215 + #7217 + #7218 and the fix from #7230

This PR adds the following low level fundchannel methods in msggen:

  • fundchannel_cancel
  • fundchannel_complete
  • fundchannel_start

@daywalker90
Copy link
Contributor Author

Notice that i changed the amount in the json schema to msat

Copy link
Member

@cdecker cdecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small issue with the change in denomination in the schema (it's sat whenever on-chain is involved, and msat otherwise).

@@ -22,7 +22,7 @@
]
},
"amount": {
"type": "sat",
"type": "msat",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is wrong:

amount is the satoshi value that we will contribute to the channel.
This value will be added to the provided PSBT in the output which is
encumbered by the 2-of-2 script for this channel.

@daywalker90
Copy link
Contributor Author

rebased on #7238

@cdecker
Copy link
Member

cdecker commented Apr 22, 2024

This was a clean rebase, I'll merge asap.

@cdecker cdecker dismissed their stale review April 22, 2024 10:21

The sat vs msat discussion predates this PR.

@cdecker
Copy link
Member

cdecker commented Apr 23, 2024

Rebased on top of master

@cdecker cdecker enabled auto-merge (rebase) April 23, 2024 15:49
@cdecker cdecker merged commit 448f4c0 into ElementsProject:master Apr 23, 2024
35 checks passed
@daywalker90 daywalker90 deleted the fundchannel_low_level branch April 24, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants