Clnrest notifications remove msat #6884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
requested changes
Nov 21, 2023
…fications_received_via_websocket` function for other rpc requests too
…om notifications
rustyrussell
force-pushed
the
clnrest-notifications-remove-msat
branch
from
b3de490 to
3cac73b
Compare
Turns out this was an underlying bug, so I've fixed that (and made the Changelog lines more general). Thanks! |
|
Working in UI as expected. |
Reported-by: Shahana Farooqui Changelog-Fixed: JSON-RPC: Plugin notification `msat` fields in `invoice_payment` and `invoice_created` hooks now a number, not a string with "msat" suffix. Changelog-Fixed: JSON-RPC: Plugin hook `payment` `msat` field is now a number, not a string with "msat" suffix.
ShahanaFarooqui
force-pushed
the
clnrest-notifications-remove-msat
branch
from
3cac73b to
d7ddde3
Compare
|
ACK d7ddde3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog-Fixed: JSON-RPC: Plugin notification
msatfields ininvoice_paymentandinvoice_createdhooks now a number, not a string with "msat" suffix.Changelog-Fixed: JSON-RPC: Plugin hook
paymentmsatfield is now a number, not a string with "msat" suffix.