cln-plugin: Make logging optional #6797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under some circumstances we may want to not log to `lightningd` directly, but rather configure the logging ourselves. This is useful for example if we want to use `tracing` and `tracing-subscriber` to add custom handling, or add opentelemetry span tracing. Changelog-Changed: cln-plugin: Suppress internal logging handler via `with_logging(false)`
vincenzopalazzo
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
ACK 9fa63c1
There is a use case where we can not use a feature flag? or it is just a matter of preference?
|
The reason to pass in a boolean is that the API already out there automatically starts the logging, and so the deviation from the existing semantics is to disable logging. This would result in a rather confusing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under some circumstances we may want to not log to
lightningddirectly, but rather configure the logging ourselves. This is useful for example if we want to usetracingandtracing-subscriberto add custom handling, or add opentelemetry span tracing.Changelog-Changed: cln-plugin: Suppress internal logging handler via
with_logging(false)