splice: first pass on splice_out command #6777
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added splice_out RPC command and a simple test of it as well. ChangeLog-Added: splice_out command added for doing a splice out more easily.
|
Should use |
niftynei
reviewed
Nov 20, 2023
| l1, l2 = node_factory.line_graph(2, fundamount=1000000, wait_for_announce=True, opts={'experimental-splicing': None}) | ||
|
|
||
| l1.rpc.splice_out(l1.get_channel_id(l2), 100000) | ||
|
|
There was a problem hiding this comment.
nit: check that the money moved!
| if (cc->auto_complete) { | ||
| subd_send_msg(channel->owner, | ||
| take(towire_channeld_splice_update(NULL, psbt))); | ||
| } |
There was a problem hiding this comment.
nit: less vertical space please
There was a problem hiding this comment.
actually let's regroup about this and talk about how to make it better!
|
|
||
| psbt_append_output(psbt, b32script, *amount); | ||
|
|
||
| weight = wally_psbt_weight(psbt); |
There was a problem hiding this comment.
i think you're going to want to add the signature witness byte weight as well, or at least an estimate for it.
|
Working on a generic splice json / script protocol that can handle doing any kind of splice. Then splice-out, splice-in, etc will use that RPC and pass it the correct json to do it. First PR in that larger project here: #6980 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added splice_out RPC command and a simple test of it as well.