Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema: Fix wrong type of CLTV in route #6642

Merged

Conversation

cdecker
Copy link
Member

@cdecker cdecker commented Aug 31, 2023

We were using number instead of u32 which caused it to be serialized to string with a decimal, which then would be rejected by lightningd.

Changelog-Fixed: proto: Fixed a wrong number type being used in routes

We were using `number` instead of `u32` which caused it to be
serialized to string with a decimal, which then would be rejected by
lightningd.

Changelog-Fixed: proto: Fixed a wrong number type being used in routes
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b509ba0

Nice catch

@rustyrussell rustyrussell added this to the v23.08 Point Releases milestone Aug 31, 2023
@rustyrussell rustyrussell merged commit 990096f into ElementsProject:master Aug 31, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants