Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msggen: Add two missing fields to the listpays schema #6441

Conversation

cdecker
Copy link
Member

@cdecker cdecker commented Jul 25, 2023

The fields were missing because they weren't annotated with a type and a description. Adding those fixes them.

Changelog-Fixed: msggen: listpays now includes the missing amount_msat and amount_sent_msat fields

@cdecker cdecker added this to the v23.08 milestone Jul 25, 2023
@cdecker cdecker force-pushed the 20230725-listpayspays-missing-amount branch 2 times, most recently from 89659dd to 1f477c9 Compare July 25, 2023 17:11
doc/schemas/listpays.schema.json Outdated Show resolved Hide resolved
@cdecker cdecker force-pushed the 20230725-listpayspays-missing-amount branch 5 times, most recently from 734934e to d9fbb94 Compare July 26, 2023 12:11
The fields were missing because they weren't annotated with a type and
a description. Adding those fixes them.

Changelog-Fixed: msggen: `listpays` now includes the missing `amount_msat` and `amount_sent_msat` fields
No-schema-diff-check: fields were always there, just undocumented!
@rustyrussell rustyrussell force-pushed the 20230725-listpayspays-missing-amount branch from d9fbb94 to d55fd50 Compare July 26, 2023 21:22
@rustyrussell
Copy link
Contributor

Ack d55fd50

(Used No-schema-diff-check magic instead of disabling in Makefile)

@rustyrussell rustyrussell merged commit 7b8ea7f into ElementsProject:master Jul 27, 2023
38 checks passed
@cdecker cdecker deleted the 20230725-listpayspays-missing-amount branch July 30, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants