bolt11: Don't push the size of the witness program for v1+ scripts #6435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For non-v0 witness programs we weren't stripping the data push byte before writing into the fallback address. According to BIP14, all witness scripts will be data pushes (up to 40-bytes) so trimming the datapush byte should be kosher. From BIP141: A scriptPubKey (or redeemScript as defined in BIP16/P2SH) that consists of a 1-byte push opcode (for 0 to 16) followed by a data push between 2 and 40 bytes gets a new special meaning. The value of the first push is called the "version byte". The following byte vector pushed is called the "witness program". Changelog-Fixed: Adding a >0 version witness program to a fallback address now is *just* the witness program, as per bolt11 spec
Merged
vincenzopalazzo
requested changes
Jul 25, 2023
Comment on lines
+415
to
+425
| if (version == 1 && tal_count(f) != 32) { | ||
| return tal_fmt(b11, | ||
| "f: witness v1 bad length %zu", | ||
| tal_count(f)); | ||
| } | ||
| if (tal_count(f) > 40) { | ||
| return tal_fmt(b11, | ||
| "f: witness v%ld bad length %zu", | ||
| version, | ||
| tal_count(f)); | ||
| } |
There was a problem hiding this comment.
we can avoid the {....} here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For non-v0 witness programs we weren't stripping the data push byte before writing into the fallback address.
According to BIP14, all witness scripts will be data pushes (up to 40-bytes) so trimming the datapush byte should be kosher.
From BIP141:
Changelog-Fixed: Adding a >0 version witness program to a fallback address now is just the witness program, as per bolt11 spec