gossipd: don't fail on gossip deletion #6297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
approved these changes
May 30, 2023
There was a problem hiding this comment.
ACK a57a67b
Make sense to me, but I am still a little bit confused why the error is telling us No such file or directory
|
I suspect this is just the problem we saw, not the whole problem. So moving the assert() out of DEVELOPER may give us more crashes? Just replace the assert with a status_broken() which prints the msg (tal_hex() will be the emtpy string if its NULL) and that other information....? |
Reported in ElementsProject#6270, there was an attempt to delete gossip overrunning the end of the gossip_store. This logs the gossip type that was attempted to be deleted and avoids an immediate crash (tombstones would be fine to skip over at least.) Changelog-None
endothermicdev
force-pushed
the
gossip-overrun-debug
branch
from
a57a67b
to
4e6681f
Compare
|
Good point. I relaxed the assert to status_broken along with the relevant information. This whole endeavor may only save us in narrow cases, but at least we'll get a clue should it happen again. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aids in debugging #6270, where there was an attempt to delete gossip which had overrun the end of the gossip store. This logs the gossip type of the deletion attempt and avoids an immediate crash. We don't know what type gossip message failed the deletion attempt, but a tombstone would be fine to skip over at least.
Changelog-None