Runes: document parameter usage, and let them be ints. #6295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niftynei
approved these changes
May 30, 2023
| @@ -427,6 +427,18 @@ static const char *check_condition(const tal_t *ctx, | |||
| if (!ptok) | |||
| return rune_alt_single_missing(ctx, alt); | |||
|
|
|||
| /* Pass through valid integers as integers. */ | |||
| if (ptok->type == JSMN_PRIMITIVE) { | |||
There was a problem hiding this comment.
cool this is much nicer than my suggestion./
vincenzopalazzo
approved these changes
Jun 3, 2023
vincenzopalazzo
approved these changes
Jun 4, 2023
This lead to confusion about how to specify `amount_msat`. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Previously any attempt would result in "is not an integer field"; we now recognize valid JSON integers as integer fields. Changelog-Fixed: Plugins: `commando` runes can now compare integer parameters using '<' and '>' as expected. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
It sometimes takes > 1800 seconds under valgrind. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
|
Marked command stresstest as slow, to prevent timeouts. Ack b1e2786 |
rustyrussell
force-pushed
the
guilt/runes-underscores
branch
from
b1e2786 to
b29732e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(based on #6294 )
Closes: #6288
I had forgotten that we already strip punctuation from parameter names, so we merely need to treat integer parameters correctly FTW. And document that
_stripping!