jsonrpc: Remove the old "_msat" prefix in the listpeerchannels command

[vincenzopalazzo]

This is a regression that we introduced in this release
due to some dirty parts of our codebase.

For historical reasons (I think), we were using a json_add_sat_only
procedure defined in peer_control.c. So when @rustyrussell removed the _msat,
we thought that all the fields were reflecting the new behavior, but
we were wrong.

This PR fixes this bug and also removes the additional function
from peer_control.c. This way, we can be sure that there is no other part
of our codebase that uses this method (except for other json_add methods).

Fixes: #6244
Reported-by: @hMsats
Signed-off-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com

[endothermicdev]

Does this upset the schema deprecation logic? It might be useful to rebase on #6242 to check. LGTM otherwise.

[vincenzopalazzo]

I do not know if the #6242 will be go in for this release.

For sure this is a bug fix and will go in, but the other one i do not know.

Does this upset the schema deprecation logic?

Mh what do you mean? the _msat should be gone in this release right?

[ShahanaFarooqui]

I do not know if the #6242 will be go in for this release.

I am leaning towards not adding this one for May release.

For sure this is a bug fix and will go in, but the other one i do not know.

Does this upset the schema deprecation logic?

Mh what do you mean? the _msat should be gone in this release right?

I believe this one is a good candidate for May release to save developers from bumping into msat removal issues in future.

[endothermicdev]

Disregard my previous comment. Just wanted to make sure it would pass make check-source but the test I was thinking of only applies if the schema itself is changed, so no need to worry about that here.

the _msat should be gone in this release right?

Definitely. ACK 6f9d0ce

[hMsats]

@ShahanaFarooqui maybe also add to CHANGELOG.md that value (unit: sats) has been removed from listfunds (and now amount_msat should be used (unit: msats)).

[rustyrussell]

Ack 6f9d0ce

[ShahanaFarooqui]

Changelog-Removed: JSON-RPC: the "msat" suffix on millisatoshi fields, as deprecated in v0.12.0.