hsmtool rune #6097
Merged
hsmtool rune #6097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
guilt/hsmtool-rune
branch
from
bd8d91e to
7872023
Compare
1. Rename get_hsm_secret to get_unencrypted_hsm_secret. 2. Create a common helper for fetching full file contents. 3. Create new routine to decrypt if necessary: get_hsm_secret(). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This way we always call it (we weren't for some paths!). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/hsmtool-rune
branch
from
7872023 to
6d4e942
Compare
ShahanaFarooqui
approved these changes
Apr 10, 2023
There was a problem hiding this comment.
The tool works as expected but the cli hangs if commando is used with this master rune without calling commando-rune first. For posterity, can we add the message You will still need to create a rune once the node starts, if you want commando to work (as it is only activated once it has generated one) somewhere in this command usage?
You still need to actually make a rune when lightningd starts, as commando (for safety) won't work unless you actually generate a rune (that it knows of!). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Added: hsmtool: `makerune` command to make a master rune for a node.
rustyrussell
force-pushed
the
guilt/hsmtool-rune
branch
from
6d4e942 to
a914288
Compare
|
OK, I added this to the documentation. There's no really great place to add it in the tool, unfortunately: the usage message is all single lines, and the output is simply the rune: if we add a warning there it gets harder to parse. |
|
ACK a914288 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows creation of a master rune before the node starts. You will still need to create a rune once the node starts, if you want commando to work (as it is only activated once it has generated one), but creating a default rune will give the identical results to the tool anyway.
Requested-by: @ShahanaFarooqui