gossipd: don't send zombie node announcements, load from store correctly #6066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can happen while loading from the store, leading to the channel announcement being ignored. This leads to a duplicate channel announcement being added, corrupting the gossip_store. Zombie channel announcements also do not need to be rebroadcast. Changelog-Fixed: gossip_store: no longer corrupted by failure to load channel announcement. Changelog-Fixed: gossipd: no longer broadcasts node_announcement without update.
Investigating ElementsProject#6065, the channel_amount gossip_store addendum may be inadvertently broadcast. Flagging it will tell any gossip_store consumers to ignore.
rustyrussell
reviewed
Mar 6, 2023
Comment on lines
73
to
81
| static inline bool is_chan_public(const struct chan *chan) | ||
| { | ||
| /* When loading from the gossip_store, zombie channels may also | ||
| * temporarily be in the unannounced channel list. However, only public | ||
| * channels may be zombies. */ | ||
| if (chan->half[0].zombie || chan->half[1].zombie) | ||
| return true; | ||
| return chan->bcast.timestamp != 0; | ||
| } |
There was a problem hiding this comment.
No, this is too ugly to live, and I can't tell what else this might break. These fields may even be uninitialized in some cases.
Let's drop this zombie flag for the point release.
|
Closed for now in favor of #6069. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses two issues with gossipd:
Node announcements were mistakenly broadcast for zombie channels (but not the update.)
Zombie flagged channels were mistaken for private channels and ignored during loading, leaving behind the original. This leads to problems for gossip store consumers and during gossip store reloading.
Changelog-Fixed: gossipd: no longer broadcasts node_announcement without update.
Changelog-Fixed: gossip_store: no longer corrupted by failure to load channel announcement.