-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output channel_id
in listfunds
#6029
Output channel_id
in listfunds
#6029
Conversation
There is CI error, but not sure how it's related to my changes. |
82cb615
to
fcd3ac8
Compare
Ok, got it, needed to also update |
Ok, I cannot figure out how to solve this error:
Apart from that, this is working, tested on my mainnet node. |
This just requires a run of I can do that for you if you'd like, just let me know ^^ |
fcd3ac8
to
5b26a95
Compare
That looks much better, thanks @kristapsk, the CI seems a bit flaky, and the failure seems unrelated, so I started another round :-) |
ACK 5b26a95 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately needs a single, one-line change! Oh, and a Changelog entry!
I've done it, since it's trivial, though!
5b26a95
to
0ae5e02
Compare
Changelog-Added: JSON-RPC: `listfunds` now has a `channel_id` field.
0ae5e02
to
20405b0
Compare
Ack 20405b0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 20405b0
See #6020 for context. This is useful, makes more easy use of
dev-forget-channel
to remove channels with no transaction in a blockchain (CHANNELD_AWAITING_LOCKIN
in my case), can givechannel_id
argument.Changelog-None