Implement flag to require confirmations for v2 opens #5900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niftynei
force-pushed
the
nifty/impl-require-confirms
branch
3 times, most recently
from
f341789
to
b4b3eea
Compare
niftynei
force-pushed
the
nifty/impl-require-confirms
branch
from
b4b3eea
to
ffa4d89
Compare
|
Rebased now prereq is merged, for review. |
|
Trivial rebase now prereq is merged. |
rustyrussell
force-pushed
the
nifty/impl-require-confirms
branch
from
ffa4d89
to
483afd2
Compare
rustyrussell
approved these changes
Feb 5, 2023
Comment on lines
+2953
to
+3011
| channel_internal_error(dualopend->channel, | ||
| "Bad DUALOPEND_VALIDATE_INPUTS: %s", | ||
| tal_hex(msg, msg)); |
There was a problem hiding this comment.
return after this (I know, shouldn't happen, but still...)
lightningd/dual_open_control.c
Outdated
Comment on lines
2657
to
2662
| static void openchannel_invalid_psbt(struct psbt_validator *pv, char *err_msg) | ||
| { |
openingd/dualopend.c
Outdated
Comment on lines
3244
to
3246
| if (state->require_confirmed_inputs[REMOTE] && | ||
| !validate_inputs(state, tx_state, state->our_role)) | ||
| return; |
There was a problem hiding this comment.
This looks a bit weird, right? Maybe get validate_inputs() to return NULL or errmsg, and then do the open_abort() here if return is non-NULL? Fits the pattern in the rest, and seems more explicit?
not amazing, since we'll probably call openchannel_update multiple times per open, but this is the simplest way to confirm that we're not sending unconfirmed outputs to peer.
We're going to use this in a bit to pass role type btw dualopend/lightningd
technically we don't need this info after the channel opens, but for any subsequent RBF (and maybe splice?) we need to remember what the open/accept peer signaled
We push this info out to the various RPCs/hooks.
`openchannel_init` takes a psbt, which we pipe over to dualopend process. If the peer requests that they'll only accept confirmed inputs, we need to go validate those before we continue. This wires up the harness for this (validation check yet tc)
Add callback methods to extant psbt validator, and expand usage to include the handling psbt validation requests from dualopend.
If set, require peers to only provide confirmed inputs for any v2 open (both in accepter + opener role)
Pass in the "validate inputs confirmed" flag from lightningd; use flag to determine whether or not to validate the inputs we've recieved from peer.
It's not likely but possible that the node's settings will shift btw a start and an RBF; we persist the setting to the database so we don't lose it. Right now holding onto it forever is kind of extra but maybe we'll reuse the setting for splices? idk. Should this be a channel type??
niftynei
force-pushed
the
nifty/impl-require-confirms
branch
from
483afd2
to
8a00ce7
Compare
|
Ack 8a00ce7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested-By: @t-bast
Respect and enable users to send a flag that requests the peer only use confirmed inputs for any v2 open request. Persists through to RBFs for the same channel as well.
Built on #5767, new commits begin at 1e09bdd