gossip: Do not send warnings if we fail to parse a channel_update
#5897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We removed a warning about the channel_update being malformed since the warning could cause lnd to disconnect (seems they treat channel-unrelated warnings as fatal?). This was caused by lnd not enforcing the `htlc_maximum`, thus the parsing would fail. We can re-add the warning once our assumption that `htlc_maximum` being set is valid. Changelog-Fixed: gossip: We no longer send warning that lnd would not understand if we get outdated gossip
endothermicdev
approved these changes
Jan 13, 2023
There was a problem hiding this comment.
It looks reasonable to swallow this warning. If we plan to reinstitute it, a log entry might help determine when it's appropriate.
ACK d788662
This was referenced Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed a warning about the channel_update being malformed since the warning could cause lnd to disconnect (seems they treat channel-unrelated warnings as fatal?). This was caused by lnd not enforcing the
htlc_maximum, thus the parsing would fail. We can re-add the warning once our assumption thathtlc_maximumbeing set is valid.Changelog-Fixed: gossip: We no longer send warning that lnd would not understand if we get outdated gossip