ld: Use htable to detect own transactions
#5715
Conversation
The list of outgoing transactions was growing with every rebroadcast. Now we just check whether it is already in the list and don't add it anymore Changelog-Fixed: ld: Reduce identification of own transactions to not slow down over time, reducing block processing time Suggested-by: Matt Whitlock <@whitslack>
We were using a quadratic lookup to locate the transactions we broadcast, so let's use an `htable` instead, allowing for constant lookups during block processing.
We had a quadratic check when processing a block, and this just reduces it to be linear. Combined with the previous fix of adding txs multiple times, this should speed up block processing considerably.
|
This is a rather simple PR, however there is one issue that I could not fix on the fly: Notice the |
Hmm, but you're removing the destructor before freeing each |
|
Yep, that was an attempt to avoid this issue, but it didn't work, which is why I'm asking here :-) |
@whitslack did an in-depth analysis of the issue at hand, and it turns out we were doing quadratic lookups on an ever increasing list of transactions we broadcast, with ever rebroadcast doubling the size of the rebroadcast list.
The first commit avoids adding the same TX multiple times, while the following two commit replace the entire list with an
htableinstead, reducing complexity to linear.Fixes #5682