Track coinbases in wallet #5664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niftynei
force-pushed
the
nifty/coinbase-utxos
branch
2 times, most recently
from
cc267eb
to
a53ed79
Compare
rustyrussell
previously requested changes
Oct 20, 2022
tests/test_opening.py
Outdated
| @@ -1898,3 +1898,22 @@ def test_zeroreserve_alldust(node_factory): | |||
| # Now try with just a bit more | |||
| l1.connect(l2) | |||
| l1.rpc.fundchannel(l2.info['id'], minfunding + 1) | |||
|
|
|||
|
|
|||
| @pytest.mark.xfail | |||
There was a problem hiding this comment.
This test is junk, it would fail even after you fix the problem!
The difference is that currently it fails with "Error broadcasting transaction: error code: -26\nerror message:\nbad-txns-premature-spend-of-coinbase, tried to spend coinbase at depth 1.", and you want a better error.
Don't change the test when you fix the problem! (Or maybe, just append to it!).
How about two inputs, one mature one not, and try to send 1000 sats and it should work? (We probably naively spend first input, so you should mine 100 blocks,then mine one to l1, then send another from bitcoind -> l1).
cdecker
reviewed
Oct 20, 2022
cdecker
force-pushed
the
nifty/coinbase-utxos
branch
from
a53ed79
to
70d7cff
Compare
Attempt to spend a coinbase transaction, expected to fail.
cdecker
force-pushed
the
nifty/coinbase-utxos
branch
2 times, most recently
from
beda83e
to
a29dcf4
Compare
Changelog-Changed: JSON-RPC: `listfunds` now lists coinbase outputs as 'immature' until they're spendable Changelog-Changed: JSON-RPC: UTXOs aren't spendable while immature
cdecker
force-pushed
the
nifty/coinbase-utxos
branch
from
58a058e
to
f9280cc
Compare
vincenzopalazzo
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark outputs as coinbases; don't spend them until they're mature.
Fixes #5564
Fixes #5696