Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blinded payments spec update and infrastructure for forwarding #5646

Merged
merged 27 commits into from
Oct 26, 2022
Merged

Blinded payments spec update and infrastructure for forwarding #5646

merged 27 commits into from
Oct 26, 2022

Conversation

rustyrussell
Copy link
Contributor

This does a pile of updates:

  • Remove x-only pubkeys from offers.
  • Update onion message and blinded payments to latest spec
  • Implement forwarding of blinded payments

This PR does not include:

  • Generating and actually paying invoices with blinded payments
  • All the offers changes after removing x-only pubkeys.

@rustyrussell rustyrussell added the protocol These issues are protocol level issues that should be discussed on the protocol spec repo label Oct 4, 2022
@rustyrussell rustyrussell added this to the v22.11 milestone Oct 4, 2022
cdecker
cdecker reviewed Oct 4, 2022
View reviewed changes
Copy link
Member

@cdecker cdecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only got as far as bd75295 for now, but wanted to start discussing the hsm_wire changes so we can avoid breaking last minute merges that could cause VLS and hsmd incompatibility.

common/gossmap.c Outdated Show resolved Hide resolved
hsmd/hsmd_wire.csv Show resolved Hide resolved
@cdecker
Copy link
Member

cdecker commented Oct 11, 2022

ACK df9cc4a

cdecker
cdecker approved these changes Oct 11, 2022
View reviewed changes
common/blindedpath.h Outdated Show resolved Hide resolved
common/features.c Show resolved Hide resolved
common/onion.c Outdated Show resolved Hide resolved
@cdecker
Copy link
Member

cdecker commented Oct 11, 2022

There seems to be a BOLT-quote mismatch somewhere:

2022-10-06T05:55:25.5455402Z common/blindedpay.c:20:mismatch:		/* BOLT #4:
2022-10-06T05:55:25.5470757Z Closest match: - For every node...[: - MUST include `am]
2022-10-06T05:55:25.5484524Z make: *** [Makefile:502: bolt-check/common/blindedpay.c] Error 1

@rustyrussell
hsmd: introduce a simple API versioning scheme.
c4b6be4 
With the rise of external HSMs like VLS, this is no longer an
internal-only API.  Fortunately, it doesn't change very fast so
maintenance should not be a huge burden.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
Makefile: check that hsm_version.h changes if wire/hsmd_wire.csv cont…
01ce207 
…ents does

Otherwise I know we'll miss it.  Simply check for a mention: we could well
change things multiple times within a single release.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
lightningd: use 33 byte pubkeys internally.
6a263d8 
We still use 32 bytes on the wire, but internally don't use x-only.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
hsmd: don't use point32 for bolt12, but use pubkeys (though still alw…
b013742 
…ays 02)

This is the one place where we hand point32 over the wire internally, so
remove it.

This is also our first hsm version change!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
bolt12: change our payer_key calculation.
b77aa11 
It was very tied to x-only keys; we could support it in a backwards
compatibility mode for a while, but getting refunds or proving old
pre-finalization invoices is not worth spending time on.

Changelog-EXPERIMENTAL: offers: old `payer_key` proofs won't work.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
gossmap: move gossmap_guess_node_id to pay plugin.
5ba948c 
This removes a point32 dependency.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
Makefile: separate bolt12 wireobjects
f9ea16b 
Most things don't want them, so don't link it into everything by default.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
BOLTs: update to more recent bolt12 spec.
94f5a09 
It's 2b7ad577d7a790b302bd1aa044b22c809c76e49d, which reverts the
point32 changes.

It also restores send_invoice in `invoice`, which we had removed
from spec and put into the recurrence patch.

I originally had implemented compatibility, but other changes
which followed this are far too widespread.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-EXPERIMENTAL: offers: complete rework of spec from other teams (yay!) breaks previous compatibility (boo!)
@rustyrussell
offers: print out more details, fix up schema for decode of blinded p…
0f65df7 
…aths.

We need to print out first_node_id, and "node_id" is now called
"blinded_node_id" in the spec.

And the schema didn't include the payment fields in the blinded path
for invoices (which broke as soon as we actually tested one!).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
Remove point32.
39881a5 
The x-only dream is dead.  Remove all trace.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
wire: add latest Route Blinding htlc fields from lightning/bolts#765
ce98096 
This is as of commit aed5518a80aade56218da87f92e0a39963b660cf

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
common: remove old route-blinding-override test, update route-blindin…
2a7a8ae 
…g test for new vectors.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
channeld: don't calculate blinding shared secret, let lightningd do it.
5de5afa 
It's a premature optimization, and it make modifications more complex.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
Copy link
Contributor Author

Yep, fixed: this is actually a quote from the route-blinding branch only.

@rustyrussell
common/blindedpath: generalize routines.
a5791ed 
We're going to share them for onion messages as well as for blinded
payments.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
common/blindedpath: generalize construction routines.
a9a7367 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
common/features: understand the route_blinding feature (feature 24)
f036961 
We don't set it, but we know how to now.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
common/onion: blinded payment support.
19fd6ec 
We make it look like a normal payment for the caller.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
common/onion: enforce payment constraints.
0fcdcc3 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
common/onion: cleanup by removing unnecessary local temporary.
1efe4a3 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
common/blindedpay: routines to construct a blinded payment.
c342175 
Don't shoehorn it into onion_nonfinal_hop() and onion_final_hop(), but
provide an explicit routine "blinded_onion_hops" and an onion helper
"onion_blinded_hop()" for it to call.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
lightningd: return invalid_onon_blinding for any blinded payment error.
9aab252 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
channeld, lightningd: allow blinded payments with !EXPERIMENTAL_FEATU…
018c609 
…RES.

Gate it (where necessary) by the route-blinding feature bit.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
common/test: check we meet bolt04/onion-route-blinding-test.json
c43bb60 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
common: update to latest onion message spec.
ddf1f3b 
Mainly, field name changes.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-EXPERIMENTAL: Protocol: Support for forwarding blinded payments (as per latest draft)
@rustyrussell
common/onion_message_parse: generic routine for parsing onion messages.
476cf5e 
Instead of open coding in connectd/onion_message, we move it to common
with a nice API.

This lets us process the BOLT test vectors.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
Copy link
Contributor Author

Trivial rebase on master, those simple typo fixes, and added (as first two commits) a new API system for hsmd_wire.csv

@rustyrussell
common/blindedpath: create onion mesage test vectors.
0152ffe 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
wire/Makefile: fix missing wire/bolt12_exp_wiregen.c in ALL_C_SOURCES.
4c25d7c 
And add it as a requirement to the test programs!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
Copy link
Contributor Author

Ack 4c25d7c

Since @cdecker approved and I need to get moving on the next PR :)

@rustyrussell rustyrussell merged commit f158b52 into ElementsProject:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdecker cdecker cdecker approved these changes

Assignees
No one assigned
Labels
protocol These issues are protocol level issues that should be discussed on the protocol spec repo
Projects
None yet
Milestone
v22.11
Development

Successfully merging this pull request may close these issues.
2 participants
@rustyrussell @cdecker