plugins/bcli: load RPC password from stdin instead of an argument #5509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
approved these changes
Aug 10, 2022
seberm
force-pushed
the
feature/load-rpc-password-from-stdin
branch
3 times, most recently
from
078fdba to
da47e8e
Compare
|
Everything should be fixed now, thanks for your review! |
|
Hmm can you add a Thanks! |
seberm
force-pushed
the
feature/load-rpc-password-from-stdin
branch
from
da47e8e to
af4335c
Compare
|
Sure, I've added the changelog info to commit message and I've fixed the order of includes. |
|
We can add the magic keyword Fixes #3984 to avoid to leave the issue open? |
|
I've added the |
Changelog-Fixed: bcli: don't expose bitcoin RPC password on commandline
rustyrussell
force-pushed
the
feature/load-rpc-password-from-stdin
branch
from
af4335c to
be29c1f
Compare
|
Trivial rebase, should kick CI. Ack be29c1f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a RPC password via cli argument (
-rpcpassword) can leak auth secrets to other users on a system (at least on Linux). This PR tries to pass the RPC password through a stdin using a-stdinrpcpassRefs.:
Fixes #3984