Dont ignore first scid for sendpay, sendonion #5505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a legacy from when it was redundant: with multiple channels, it no longer is! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Reported-by: Warren Togami Changelog-Changed: `sendpay` and `sendonion` now obey the first hop "channel" short_channel_id, if specified. Changelog-Deprecated: `sendpay` and `sendonion` could take a bogus first hop "channel" short_channel_id
nepet
approved these changes
Aug 8, 2022
…irst_hop channel. This was always the case, though it was ignored. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/sendpay-dont-ignore-first-scid
branch
from
a935d2a to
566ef57
Compare
|
I reverted the fix to the sendonion request schema, as that broke the rust stuff... |
|
Ok, maybe I was too fast before but still, the changes on pay seem good and ci seems to be happy now, so again: Ack 566ef57 |
|
ACK 566ef57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5504
@niftynei Note new Changelog entries!!