bookkeeper: dont skip zero balance channels that are missing #5503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niftynei
force-pushed
the
nifty/bkpr-missed-acct
branch
from
751f13b
to
ec3a50a
Compare
we weren't making records for 'missed' accounts that had a zero balance at snapshot time (if peer opens channel and is unused) Fixes: ElementsProject#5502 Reported-By: https://github.com/niftynei/cln-logmaid
niftynei
force-pushed
the
nifty/bkpr-missed-acct
branch
from
ec3a50a
to
3d9ff53
Compare
niftynei
commented
Aug 10, 2022
| @@ -145,7 +145,7 @@ def test_bookkeeping_external_withdraws(node_factory, bitcoind): | |||
| assert inc['credit_msat'] == amount_msat | |||
| # The event should show up in the 'bkpr_listaccountevents' however | |||
| events = l1.rpc.bkpr_listaccountevents()['events'] | |||
| assert len(events) == 3 | |||
| assert len(events) == 4 | |||
There was a problem hiding this comment.
we now record an extra event for wallet balances (starting at zero)
|
Ack 3d9ff53 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't adding zero balance channels during "catch up starts (accounting for things missing while bookkeeper wasn't running)", which resulted in a crash/restart when any payment got routed through these channels.
Also patches a flake (which really needs a nicer fix than this line/by line patch but yolo) and removes a duplicated log statement.
Changelog-None.