Some minor changes in the CLN crates #5493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
force-pushed
the
cln-plugin-rework
branch
2 times, most recently
from
dd4a10c to
e7be122
Compare
cdecker
force-pushed
the
cln-plugin-rework
branch
from
16cfe87 to
64b9804
Compare
cdecker
force-pushed
the
cln-plugin-rework
branch
8 times, most recently
from
5065dba to
cca27a9
Compare
cdecker
changed the title
cdecker
force-pushed
the
cln-plugin-rework
branch
2 times, most recently
from
ec90055 to
fd5adbc
Compare
We had a bit of a chicken-and-egg problem, where we instantiated the `state` to be managed by the `Plugin` during the very first step when creating the `Builder`, but then the state might depend on the configuration we only get later. This would force developers to add placeholders in the form of `Option` into the state, when really they'd never be none after configuring. This defers the binding until after we get the configuration and cleans up the semantics: - `Builder`: declare options, hooks, etc - `ConfiguredPlugin`: we have exchanged the handshake with `lightningd`, now we can construct the `state` accordingly - `Plugin`: Running instance of the plugin Changelog-Changed: cln-plugin: Moved the state binding to the plugin until after the configuration step
We filter based on the environment variable `CLN_PLUGIN_LOG`, defaulting to `info` as that is not as noisy as `debug` or `trace`, at least libraries will not spam us too heavily. Changelog-Added cln-plugin: The logs level from cln-plugins can be configured by the `CLN_PLUGIN_LOG` environment variable.
I wanted to debug why we weren't getting some log messages, and this makes that a bit easier in future.
We needed to clone a lot since we were using a non-mutable borrow of the cln-rpc version to then create the cln-grpc version. This alone reduces the number of allocations of the `listpeers` test from 52 allocations to 38.
cdecker
force-pushed
the
cln-plugin-rework
branch
from
fd5adbc to
e7c7f14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are based on feedback and dogfooding experiences, please keep them coming 😉