Deprecations and spec updates post-0.12 #5490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
guilt/deprecations-and-spec-updates
branch
from
f082259
to
f43bc2e
Compare
rustyrussell
force-pushed
the
guilt/deprecations-and-spec-updates
branch
2 times, most recently
from
a86468d
to
cd84f44
Compare
rustyrussell
force-pushed
the
guilt/deprecations-and-spec-updates
branch
from
cd84f44
to
820219b
Compare
|
Rebased, fixed one place in tests where I missed "WIRE_FUNDING_LOCKED"->"WIRE_CHANNEL_READY". |
rustyrussell
force-pushed
the
guilt/deprecations-and-spec-updates
branch
from
820219b
to
16bd160
Compare
This FIXME caught my eye, as it's wrong: TLVs are canonical, so they cannot differ in bits and be equal. The equality function needs to be written correctly, however, otherwise it will crash! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
In particular, we didn't check the remote_addr in the init msg. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…r_internal. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Somehow we missed this deprecation, found by grep. Changelog-Removed: JSON API: Removed double wrapping of `rpc_command` payload in `rpc_command` JSON field (deprecated v0.8.2) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Removed: JSONRPC: RPC framework now requires the `"jsonrpc"` property inside the request (deprecated in v0.10.2) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Removed: Old order of the `status` parameter in the `listforwards` rpc command (deprecated in v0.10.2) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We can do this now the function is cleaned up. Always better to do the work inside param() since then `check` gets the benefit. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Removed: JSON-RPC: plugins must supply `usage` parameter (deprecated v0.7) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Removed: Plugins: plugin init `use_proxy_always` (deprecated v0.10.2) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
… set it. It was deprecated in v0.10.1, but only one channel on the network doesn't set it now anyway, and we'll be ignoring that soon. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-EXPERIMENTAL: remove "vendor" (use "issuer") and "timestamp" (use "created_at") fields (deprecated v0.10.2).
We changed the field name in v0.11.0, so this breaks compat with v0.10.2. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…indescriptors`. Changelog-Removed: `hsmtool`: hsm_secret (ignored) on cmdline for dumponchaindescriptors (deprecated in v0.9.3) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
… time. This would be more effective if we didn't *merge* in the specs repo, but still. Usage: ./devtools/bolt-catchup.sh It goes through one commit at a time, up to current HEAD, and stops when there are changes, or quotes change. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
`flags` in `channel_disabled` gets renamed. We don't use it anyway. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This contains the zeroconf stuff, with funding_locked renamed to channel_ready. I change that everywhere, and try to fix up the comments. Also the `alias` field is called `short_channel_id`. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Changed: Protocol: `funding_locked` is now called `channel_ready` as per latest BOLTs.
This alters the billboard, but that's a human-readable thing so not noted in CHANGELOG. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Changed: JSON-RPC: `listpeers` `status` now refers to "channel ready" rather than "funding locked" (BOLT language change for zeroconf channels) Changelog-Added: JSON-RPC: `channel_opened` notification `channel_ready` flag. Changelog-Deprecated: JSON-RPC: `channel_opened` notification `funding_locked` flag (use `channel_ready`: BOLTs namechange).
I disagree with this change, so I've commented and added a FIXME. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This is a slightly looser behavior, so no change needed. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This includes the recommendation that we use 10 minute grace period, so add quotes to where we use that. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/deprecations-and-spec-updates
branch
from
16bd160
to
380ee93
Compare
Sjors
reviewed
Dec 3, 2022
| } | ||
| jsonrpc = json_get_member(buffer, replacetok, "jsonrpc"); | ||
| if (!jsonrpc || jsonrpc->type != JSMN_STRING || !json_tok_streq(buffer, jsonrpc, "2.0")) { | ||
| bad = "jsonrpc: \"2.0\" must be specified in the request"; |
There was a problem hiding this comment.
I think this broke the BTCPay server integration… cc @NicolasDorier
There was a problem hiding this comment.
The broken part is the RPC library used inside it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.