Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Channel Backups (we confused Github) #5422

Merged
merged 10 commits into from
Jul 14, 2022

Conversation

niftynei
Copy link
Collaborator

These are the commits we'd expect to see in #5288 , however @niftynei managed to confuse github.

We have learned a valuable lesson about using branches for development, not master.

@niftynei niftynei requested a review from cdecker as a code owner July 13, 2022 16:03
@niftynei niftynei added this to the v0.12 milestone Jul 13, 2022
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e0b82ba

@niftynei niftynei merged commit 7b160b2 into ElementsProject:master Jul 14, 2022
@adi2011
Copy link
Collaborator

adi2011 commented Jul 14, 2022

🥳
🍻

Copy link
Collaborator

@ZmnSCPxj ZmnSCPxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also deserves to update doc/BACKUP.md.

@@ -0,0 +1,38 @@
lightning-staticbacup -- Command for deriving getting SCB of all the existing channels
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misspelled lightning-staticbacup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants