Fixes #5276 by using debian bullseye instead of buster #5278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
approved these changes
May 20, 2022
There was a problem hiding this comment.
LGTM, looks like the only way to update the library is to update the base docker image, and have error has gone good because unlock the possibility to use rust lib provided in a cool way too!
ACK 1c61828
Your PRs are fine, the only optional thing is the Changelog-None entry in the commit body!
|
I added it as Changelog-Fixed: Upgrade docker base image from Debian buster to bullseye to work with glibc 2.29+ |
|
This needs squashing, and the |
…eye instead of buster Changelog-Fixed: Upgrade docker base image from Debian buster to bullseye to work with glibc 2.29+ ElementsProject#5276
|
@cdecker Squashing done, hope it is ok now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5276
I've tested the upgrade with plugins that requires GLIBC 2.29+ when compiled with Rust and it works, shall I test something more for this PR?
This is is my first contribution here, guidance is very welcome