Polish feature remote_addr #5244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog-Changed: connectd: prefer IPv6 connections when available.
...So it can be reused somewhere else Changelog-None
Changelog-Fixed: JSON-RPC: Adds dynamically detected public IP addresses to `getinfo`
m-schmoock
force-pushed
the
fix/remote_addr
branch
from
eb902fd to
82f6289
Compare
Before this fix, there was the situation where a DEVELOPER=1 node would announce non-public addresses on mainnet if detected. Since there are some nodes on the internet that falsely report local addresses we move this 'testing feature' to 'dev-allow-locahost' nodes. Changelog-None
m-schmoock
force-pushed
the
fix/remote_addr
branch
from
82f6289 to
38a0032
Compare
Changelog-Added: jsonrpc: adds optional `remote_addr` to listpeers
m-schmoock
force-pushed
the
fix/remote_addr
branch
from
38a0032 to
36baf23
Compare
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the feature is out in the wild, I see several improvements that can be made:
getinfoRPC. This was missed in prior PR.remote_addrfrom peers that cannot be confirmed other peers (see Fill ininit.remote_addrfrom front machines ACINQ/eclair#2256 ). Note: This currently does not produce false positives, but 'interrupts' the detection of the correct address.remote_addrfield tolistpeersRPC.