Add a `bookkeeper` plugin #5071

niftynei · 2022-03-04T22:24:09Z

Bookkeeper plugin keeps track of all the coin movements that happen on the attached clightning node. It also exposes a number of commands for inspecting these events, as well as some 'on top' accounting to figure out what you've spent on onchain fees.

bkpr-listbalances: shows all accounts and their balances (a channel is an account)
bkpr-listaccountevents: dump of all raw events (incl onchain fee updates, as they happen). Can be filtered by account
bkpr-inspect: show the onchain footprint of this account. Nice for seeing unilateral close resolution progress.
bkpr-listincome: list every 'income impacting' event (internal transfers etc are filtered). Defaults to consolidating fees.
bkpr-dumpincomecsv: Dump out the income events to a csv formatted for a given provider. Options include: cointracker, koinly, harmony, and quickbooks.
bkpr-channelsapy: Summary of fees earned on incoming/outgoing payments and fee leases on a channel by channel basis.

Note that any coin movements that occurred before the bookkeeper plugin was initialized won't be counted.

rustyrussell · 2022-03-05T04:47:55Z

Ok, I've merged the prerequisites....

cdecker

Just some preliminary remarks and questions up to commit bd3252a, will continue the review later today.

cdecker · 2022-03-09T13:08:48Z

plugins/bkpr/db.c

+ * It is used to migrate existing databases from a prevoius state, based on
+ * string indicies */
+static struct migration db_migrations[] = {
+	{SQL("CREATE TABLE version (version INTEGER);"), NULL},


Can we prefix the tables with something (bkp_?) otherwise we'll have to provision two databases for the postgres case. With a prefix we could just assign the same database and have the plugin and lightningd share it.

well that'd mean that db/exec.c needs a way to add a prefix to table names. otherwise, seems like a great idea.

Probably a tall ask, but why a separate database? Could we use datastore instead?

iiuc datastore is designed for key-value storage; this application requires more complex relational data storage.

All relational data storage is based on key-value ultimately (tables have a row ID per row that is the key to the tuple, and indices map tuple values to row ID keys), though I do understand wanting not to have to reimplement SQL when a perfectly good library already exists.

In particular, this seems to be recordkeeping that is "safe" to lose; you lose your records, but none of your funds are at risk if the bookkeeper-specific database is lost due to inevitable hardware failure. So not using datastore is fine. But I think you should also point this out in the docs, then, that since it is not stored in lightningd.sqlite3 or in the PostgreSQL database, then any automated backup/replication setup the user uses does not apply to the bookkeeper data, and if the user recovers from any failure safely, the bookkeeper data is lost.

Of note is that even if you adapt to PostgreSQL, PostgreSQL users may need to set up a separate database for this bookkeeper, due to the use of a table name (CREATE TABLE version) that is the same as the "main" lightningd database. This complicates an already complicated deployment.

cdecker · 2022-03-09T13:11:44Z

plugins/bkpr/db.c

+		", tag VARCHAR(255)"
+		", credit BIGINT"
+		", debit BIGINT"
+		", output_value BIGINT"
+		", currency VARCHAR(12)"
+		", timestamp BIGINT"
+		", blockheight INTEGER"
+		", utxo_txid BLOB"
+		", outnum INTEGER"
+		", spending_txid BLOB"


Are all these field not nullable?

spending_txid is. should I add a default NULL? i thought fields were null by default.

plugins/libplugin.h

plugins/bkpr/recorder.c

cdecker · 2022-03-10T09:36:34Z

plugins/bkpr/bookkeeper.c

+	if (e->spending_txid)
+		err = maybe_update_onchain_fees(cmd, db, e->spending_txid);
+	else
+		err = maybe_update_onchain_fees(cmd, db, &e->outpoint.txid);


Ok, took me a while to find the difference in the two lines. Can we have a local variable with a descriptive name that we then call to a single call instead? Would make following along a bit easier.

what about

err = maybe_update_onchain_fees(cmd, db, e->spending_txid ? e->spending_txid : &e->outpoint.txid)

plugins/bkpr/recorder.c

cdecker · 2022-03-10T09:50:21Z

plugins/bkpr/recorder.c

-	/* Otherwise, we update the existing record */
-	db_col_ignore(stmt, "1");
+		if (!amount_msat_sub(&current_amt, current_amt, debit))
+			db_fatal("Overflow when adding onchain fees");


Overflow when adding -> Underflow while subtracting

cdecker · 2022-03-10T10:05:24Z

plugins/bkpr/bookkeeper.c

+	db_begin_transaction(db);
+	log_channel_event(db, acct, chan_ev);
+	db_commit_transaction(db);


General: it's often easier and even faster to just wrap the entire event handling in a single large DB transaction rather than trying to do fine-grained control, which may lead to accidentally nested transactions (-> abort), and many transactions being started and committed. Also the one-to-one mapping between event and DB transaction ensure that we don't get partially handled events in case of a crash.

cdecker · 2022-03-10T10:23:20Z

plugins/bkpr/bookkeeper.c

+		struct channel_event *chan;
+		struct chain_event *chain;
+		struct onchain_fee *fee;
+		u64 lowest = 0;


Why not set this to UINT64_MAX? Allows you to treat the "no lowest" case identical to "higher lowest" case.

In addition is seems that this assumes that there'll always be a fee to add at the end, wouldn't it be easier to do a merge-sort like structure where each iteration pops the lowest and prints that before restarting the iteration? This code might get the ordering wrong if we have two consecutive events of the same type followed by a later event, since this will at most print one event for each type before switching to the next type (though there may be a structure in the model I'm not considering here).

this will at most print one event for each type before switching to the next type

We only print one item every loop, there are continues at each print action that ensures that there's only one per.

this assumes that there'll always be a fee to add at the end

Since we continue after print, you'll never reach the fee print line if you're out of fees -- another item will have printed and the loop continued.

Generally speaking, the routine here is:

elect the top item of each list

from all (still populated) elected items, which has the lowest timestamp?

print that (with some preference for channel, then chain, then fees in case of a tie)

return to election phase

I could merge the lowest timestamp identification and 'topmost item' selection.

niftynei · 2022-03-12T02:06:19Z

Based on comments from @cdecker, I rewrote the way that the account_get_balance function works to use the SUM() methods in SQL. Perhaps foolishly, I embraced the 'maybe this account has multiple currencies' idea and rewrote the interface to return the balances segmented by 'currency', which had some rippling impacts throughout the rest of the stuff, but it's mostly been folded in. I'm a glutton for big patchsets aren't I.

1f364f9#diff-ae7e6b3b74048f72d90eac244f2b7eda49ee6637cf323de3f3cdd2b9af179ed8R197

I wasn't sure about the best way to handle adding a prefix to a table name for the tables, since the shared database code expects certain tables. A better refactorer would probably pull the part of the database migrations out that are expected/core into a top-level thing or something..

michaelfolkson · 2022-03-17T10:45:43Z

Concept ACK

Is the plan that you'll get this working in this repo first and then move the plugin specific stuff (bookkeeper database etc) to the plugins repo? This is essentially laying the groundwork for others to write accounting plugins longer term right? (If there was reason to of course, perhaps this bookkeeper plugin will literally do everything a user could wish for re accounting).

rustyrussell · 2022-03-24T04:35:22Z

Looks like valgrind found something...

bertmiller · 2022-03-26T02:36:40Z

lgtm!

rustyrussell · 2022-03-27T23:14:57Z

After discussion with @niftynei I am bumping this to next release....

rustyrussell

Only reviewed half, but minor comments. Mainly, needs rebase and thwacking CI AFAICT...

rustyrussell · 2022-07-17T12:35:49Z

connectd/test/run-netaddress.c

+	return 0;
 }


This is unnecessary in modern C. And I guess from the commit message, this is simply a rind left over from a previous commit which added common_shutdown() and is now redundant?

removed! (deleted whole commit, was extraneous)

plugins/bkpr/account.c

plugins/bkpr/bookkeeper.c

doc/lightningd-config.5.md

rustyrussell · 2022-07-19T07:24:43Z

Rebased on master, and reordered and fixed deps so it's possible to bisect, also fixed db_fatal() in plugin to show up in logs. Did some minor fixups which were obvious.

The following tests are broken:

tests/test_closing.py::test_onchain_their_unilateral_out
tests/test_closing.py::test_penalty_htlc_tx_timeout
tests/test_opening.py::test_zeroconf_forward
tests/test_opening.py::test_zeroconf_open

The zeroconf ones seem like a conflict introduced in the rebase:

lightningd-2 2022-07-19T07:23:59.871Z **BROKEN** plugin-bookkeeper: Received channel event, but no account exists 6cb8d54790e10d5e368681f33a15e9b1a651ed218996cfb804cc5825e4d010c1

Utility method to figure out if an account is "external"

If two events for the same (unlogged) account come in and get run through the "lookup peer" code, we should anticipate that. We do two things here: - one, if it's a duplicate "event" to create the channel open we check for that and just exit early - two, we were using a copy of the account that was fetched/pulled from before the RPC ran, so instead we just re-pull the most up to date account info for the close checks. This fixes the crash I was getting in re-running these things

We weren't passing the command, which meant that it wasn't getting populated correctly. We do that now, it fixes some crashes

It's possible we'll get an "external" event for an account/channel and then try to do close checks on it and it'll bomb out because we didn't go look up the originating account to make sure that that had open info Now, we make sure and do that when we hear about an originating account

We rescan and pick up the channel's close tx, but can't go back and get the open info, since we've already deleted the channel from the database.

nice to have for making tests that assert on description/bolt data

It'll be really nice to be able to read description data about an invoice, if we've got it!

So we print out invoice fees on the same line for those CSVs! This means we have to do a little bit of gymnastics (but not too bad): - we save the fee amount onto the income event now so we can use it later - we ignore every "invoice_fee" event for the koinly/cointracker Note that since we're not skipping income events in the loops we also move the newline character to the start of every `_entry` function so skipped records dont incur empth lines. Changelog-Added: bkpr: print out invoice fees on the same line for `koinly` and `cointracker` csv types

First off, when we pull data out of JSON, unescape it so we don't end up with extraneous escapes in our bookkeeping data. I promise, it's worth it. Then, when we print descriptions out to the csvs, we gotta wrap everything in quotes... but also we have to change all the double-quotes to singles so that adding the quotes doesn't do anything untoward. We also just pass it thru json_escape to get rid of linebreaks etc. Note that in the tests we do a byte comparison instead of converting the CSV dumps to strings because python will escape the strings on conversion...

FXIME: Has a edge case where if you disable the bookkeeper, it'll blowup because you've got an option that isn't present anywhere...

`lightningd` has an option --wallet that lets you supply a database dsn string to connect to a sqlite3/postgres database that's hosted/stored elsewhere. This adds the `--bookkeeper-db` option which does the same, except for the bookkeeping data for a node! Note that the default is to go in the `lightning-dir` in a database called `accounts.sqlite3`

@niftynei

…ce everyone needs it. This was originally done as part of the bookkeeper introduction, but it deserves its own patch (and that one didn't remove the bitcoin/chainparams.o from the individual requirements lines). Suggested-by: @niftynei Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

…gin. We do this for bcli options, too. Good to note if people disable/replace the plugin. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Somehow these two were missed in 79e09b9. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

niftynei · 2022-07-27T21:41:31Z

da742b5: now emits a new event type "channel_proposed" for zeroconfs

4822c54: keeps all the events. inspect now does a little sleigh of hand now as it hides the proposed event after an open happens.

We need a record of the channel account before you start sending payments through it. Normally we don't start allowing payments to be sent until after the channel has locked in but zeroconf does away with this assumption. Instead we push out a "channel_proposed" event, which should only show up for zeroconfs.

Keep the accounts as an 'append only' log, instead we move the marker for the 'channel_open' forward when a 'channel_open' comes out. We also neatly hide the 'channel_proposed' events in 'inspect' if there's a 'channel_open' for that same event. If you call inspect before the 'channel_open' is confirmed, you'll see the tag as 'channel_proposed', afterwards it shows up as 'channel_open'. However the event log rolls forward -- listaccountevents will show the correct history of the proposal then open confirming (plus any routing that happened before the channel confirmed).

memleak was complaining about dangling refs; they were all allocated off of `cmd` but not technically unreachabe from any in-context memory. Instead we move things over to tmpctx to clean up (in the paths where we're going to move the objects out of reach via intermediate RPC call) ALSO: cleans up unused param in `lookup_invoice_desc` lightningd-1 2022-07-23T19:17:11.192Z **BROKEN** plugin-bookkeeper: MEMLEAK: 0x1511f68 lightningd-1 2022-07-23T19:17:11.194Z **BROKEN** plugin-bookkeeper: label=plugins/bkpr/recorder.c:1048:struct account lightningd-1 2022-07-23T19:17:11.194Z **BROKEN** plugin-bookkeeper: backtrace: lightningd-1 2022-07-23T19:17:11.194Z **BROKEN** plugin-bookkeeper: ccan/ccan/tal/tal.c:442 (tal_alloc_) lightningd-1 2022-07-23T19:17:11.194Z **BROKEN** plugin-bookkeeper: plugins/bkpr/recorder.c:1048 (stmt2account) lightningd-1 2022-07-23T19:17:11.194Z **BROKEN** plugin-bookkeeper: plugins/bkpr/recorder.c:1109 (find_account) lightningd-1 2022-07-23T19:17:11.196Z **BROKEN** plugin-bookkeeper: plugins/bkpr/bookkeeper.c:1606 (parse_and_log_channel_move) lightningd-1 2022-07-23T19:17:11.197Z **BROKEN** plugin-bookkeeper: plugins/bkpr/bookkeeper.c:1713 (json_coin_moved) lightningd-1 2022-07-23T19:17:11.198Z **BROKEN** plugin-bookkeeper: plugins/libplugin.c:1421 (ld_command_handle) lightningd-1 2022-07-23T19:17:11.198Z **BROKEN** plugin-bookkeeper: plugins/libplugin.c:1491 (ld_read_json_one) lightningd-1 2022-07-23T19:17:11.199Z **BROKEN** plugin-bookkeeper: plugins/libplugin.c:1511 (ld_read_json) lightningd-1 2022-07-23T19:17:11.199Z **BROKEN** plugin-bookkeeper: ccan/ccan/io/io.c:59 (next_plan) lightningd-1 2022-07-23T19:17:11.199Z **BROKEN** plugin-bookkeeper: ccan/ccan/io/io.c:407 (do_plan) lightningd-1 2022-07-23T19:17:11.199Z **BROKEN** plugin-bookkeeper: ccan/ccan/io/io.c:417 (io_ready) lightningd-1 2022-07-23T19:17:11.199Z **BROKEN** plugin-bookkeeper: ccan/ccan/io/poll.c:453 (io_loop) lightningd-1 2022-07-23T19:17:11.199Z **BROKEN** plugin-bookkeeper: plugins/libplugin.c:1708 (plugin_main) lightningd-1 2022-07-23T19:17:11.199Z **BROKEN** plugin-bookkeeper: plugins/bkpr/bookkeeper.c:1812 (main) lightningd-1 2022-07-23T19:17:11.200Z **BROKEN** plugin-bookkeeper: ../csu/libc-start.c:308 (__libc_start_main) lightningd-1 2022-07-23T19:17:11.200Z **BROKEN** plugin-bookkeeper: parents: lightningd-1 2022-07-23T19:17:11.200Z **BROKEN** plugin-bookkeeper: plugins/libplugin.c:1378:struct command lightningd-1 2022-07-23T19:17:11.200Z **BROKEN** plugin-bookkeeper: MEMLEAK: 0x15305b8 lightningd-1 2022-07-23T19:17:11.200Z **BROKEN** plugin-bookkeeper: label=plugins/bkpr/bookkeeper.c:1643:enum mvt_tag[] lightningd-1 2022-07-23T19:17:11.200Z **BROKEN** plugin-bookkeeper: backtrace: lightningd-1 2022-07-23T19:17:11.200Z **BROKEN** plugin-bookkeeper: ccan/ccan/tal/tal.c:442 (tal_alloc_) lightningd-1 2022-07-23T19:17:11.201Z **BROKEN** plugin-bookkeeper: ccan/ccan/tal/tal.c:471 (tal_alloc_arr_) lightningd-1 2022-07-23T19:17:11.201Z **BROKEN** plugin-bookkeeper: plugins/bkpr/bookkeeper.c:1643 (parse_tags) lightningd-1 2022-07-23T19:17:11.201Z **BROKEN** plugin-bookkeeper: plugins/bkpr/bookkeeper.c:1686 (json_coin_moved) lightningd-1 2022-07-23T19:17:11.201Z **BROKEN** plugin-bookkeeper: plugins/libplugin.c:1421 (ld_command_handle) lightningd-1 2022-07-23T19:17:11.201Z **BROKEN** plugin-bookkeeper: plugins/libplugin.c:1491 (ld_read_json_one) lightningd-1 2022-07-23T19:17:11.201Z **BROKEN** plugin-bookkeeper: plugins/libplugin.c:1511 (ld_read_json) lightningd-1 2022-07-23T19:17:11.201Z **BROKEN** plugin-bookkeeper: ccan/ccan/io/io.c:59 (next_plan) lightningd-1 2022-07-23T19:17:11.201Z **BROKEN** plugin-bookkeeper: ccan/ccan/io/io.c:407 (do_plan) lightningd-1 2022-07-23T19:17:11.202Z **BROKEN** plugin-bookkeeper: ccan/ccan/io/io.c:417 (io_ready) lightningd-1 2022-07-23T19:17:11.202Z **BROKEN** plugin-bookkeeper: ccan/ccan/io/poll.c:453 (io_loop) lightningd-1 2022-07-23T19:17:11.202Z **BROKEN** plugin-bookkeeper: plugins/libplugin.c:1708 (plugin_main) lightningd-1 2022-07-23T19:17:11.203Z **BROKEN** plugin-bookkeeper: plugins/bkpr/bookkeeper.c:1812 (main) lightningd-1 2022-07-23T19:17:11.204Z **BROKEN** plugin-bookkeeper: ../csu/libc-start.c:308 (__libc_start_main) lightningd-1 2022-07-23T19:17:11.204Z **BROKEN** plugin-bookkeeper: parents: lightningd-1 2022-07-23T19:17:11.204Z **BROKEN** plugin-bookkeeper: plugins/libplugin.c:1378:struct command lightningd-1 2022-07-23T19:17:11.204Z **BROKEN** plugin-bookkeeper: MEMLEAK: 0x1508da8 lightningd-1 2022-07-23T19:17:11.204Z **BROKEN** plugin-bookkeeper: label=plugins/bkpr/bookkeeper.c:1568:struct channel_event lightningd-1 2022-07-23T19:17:11.204Z **BROKEN** plugin-bookkeeper: backtrace: lightningd-1 2022-07-23T19:17:11.204Z **BROKEN** plugin-bookkeeper: ccan/ccan/tal/tal.c:442 (tal_alloc_) lightningd-1 2022-07-23T19:17:11.204Z **BROKEN** plugin-bookkeeper: plugins/bkpr/bookkeeper.c:1568 (parse_and_log_channel_move) lightningd-1 2022-07-23T19:17:11.204Z **BROKEN** plugin-bookkeeper: plugins/bkpr/bookkeeper.c:1713 (json_coin_moved) lightningd-1 2022-07-23T19:17:11.205Z **BROKEN** plugin-bookkeeper: plugins/libplugin.c:1421 (ld_command_handle) lightningd-1 2022-07-23T19:17:11.205Z **BROKEN** plugin-bookkeeper: plugins/libplugin.c:1491 (ld_read_json_one) lightningd-1 2022-07-23T19:17:11.205Z **BROKEN** plugin-bookkeeper: plugins/libplugin.c:1511 (ld_read_json) lightningd-1 2022-07-23T19:17:11.205Z **BROKEN** plugin-bookkeeper: ccan/ccan/io/io.c:59 (next_plan) lightningd-1 2022-07-23T19:17:11.205Z **BROKEN** plugin-bookkeeper: ccan/ccan/io/io.c:407 (do_plan) lightningd-1 2022-07-23T19:17:11.205Z **BROKEN** plugin-bookkeeper: ccan/ccan/io/io.c:417 (io_ready) lightningd-1 2022-07-23T19:17:11.205Z **BROKEN** plugin-bookkeeper: ccan/ccan/io/poll.c:453 (io_loop) lightningd-1 2022-07-23T19:17:11.205Z **BROKEN** plugin-bookkeeper: plugins/libplugin.c:1708 (plugin_main) lightningd-1 2022-07-23T19:17:11.205Z **BROKEN** plugin-bookkeeper: plugins/bkpr/bookkeeper.c:1812 (main) lightningd-1 2022-07-23T19:17:11.206Z **BROKEN** plugin-bookkeeper: ../csu/libc-start.c:308 (__libc_start_main) lightningd-1 2022-07-23T19:17:11.206Z **BROKEN** plugin-bookkeeper: parents: lightningd-1 2022-07-23T19:17:11.206Z **BROKEN** plugin-bookkeeper: plugins/libplugin.c:1378:struct command

rustyrussell · 2022-07-27T23:59:07Z

plugins/bkpr/recorder.c

@@ -225,7 +225,8 @@ static struct chain_event **find_txos_for_tx(const tal_t *ctx,
 				     " ORDER BY "
 				     "  e.utxo_txid"
 				     ", e.outnum"
-				     ", e.spending_txid NULLS FIRST"));
+				     ", e.spending_txid NULLS FIRST"


NULLS FIRST, hmm, I've never seen that before! TIL...

rustyrussell

Ack da5d702

rustyrussell · 2022-07-28T02:38:06Z

Ack 4522951

niftynei added the plugin label Mar 4, 2022

niftynei added this to the v0.11 milestone Mar 4, 2022

niftynei requested review from ZmnSCPxj and cdecker as code owners March 4, 2022 22:24

niftynei force-pushed the nifty/acct_plugin branch 3 times, most recently from e510940 to 03e4fd4 Compare March 7, 2022 20:57

cdecker reviewed Mar 10, 2022

View reviewed changes

niftynei force-pushed the nifty/acct_plugin branch 2 times, most recently from bca7618 to 10b3547 Compare March 12, 2022 01:50

niftynei force-pushed the nifty/acct_plugin branch 4 times, most recently from 83513f5 to b1cf937 Compare March 16, 2022 18:07

niftynei force-pushed the nifty/acct_plugin branch from ef7d476 to 43fdff9 Compare March 21, 2022 18:59

niftynei force-pushed the nifty/acct_plugin branch from 52340e3 to 6b94c93 Compare March 24, 2022 19:05

rustyrussell modified the milestones: v0.11, v0.12 Mar 27, 2022

niftynei force-pushed the nifty/acct_plugin branch 3 times, most recently from 0c3d53f to 93f68eb Compare July 13, 2022 21:03

rustyrussell approved these changes Jul 17, 2022

View reviewed changes

rustyrussell force-pushed the nifty/acct_plugin branch from 93f68eb to f6c9fbc Compare July 19, 2022 07:21

niftynei and others added 16 commits July 27, 2022 12:56

bkpr: duplicate the name, dont steal it

04f2b30

bkpr: new method, "is_external_account"

0c5f47a

Utility method to figure out if an account is "external"

bkpr: more logging

2756234

bkpr: correctly pass in command for jsonrpc_request_start

c3902a5

We weren't passing the command, which meant that it wasn't getting populated correctly. We do that now, it fixes some crashes

bkpr: add test for bookkeeper being added after channel has closed

a75a3ac

We rescan and pick up the channel's close tx, but can't go back and get the open info, since we've already deleted the channel from the database.

test-utils: add the bolt11 invoice

75fc67f

nice to have for making tests that assert on description/bolt data

bkpr: save invoice description data to the database and display it

13c60a6

It'll be really nice to be able to read description data about an invoice, if we've got it!

test-db-provider: if postgres in tests, startup a bookkeeper db

853f03e

FXIME: Has a edge case where if you disable the bookkeeper, it'll blowup because you've got an option that isn't present anywhere...

doc: note that bookkeeper-dir and bookkeeper-db are in bookkeeper plu…

760323f

…gin. We do this for bcli options, too. Good to note if people disable/replace the plugin. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

doc: remove two more generated manpages.

0f07431

Somehow these two were missed in 79e09b9. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

niftynei force-pushed the nifty/acct_plugin branch from 3a1c228 to e3c907b Compare July 27, 2022 21:36

niftynei force-pushed the nifty/acct_plugin branch from e3c907b to e6e2a3b Compare July 27, 2022 21:46

niftynei changed the title ~~Add a bookkeeper plugin to clightning~~ Add a bookkeeper plugin Jul 27, 2022

niftynei added 3 commits July 27, 2022 17:36

nit: send_outreq returns &pending, no need to call sep command

43814b6

niftynei force-pushed the nifty/acct_plugin branch from e6e2a3b to da5d702 Compare July 27, 2022 22:37

rustyrussell reviewed Jul 27, 2022

View reviewed changes

rustyrussell approved these changes Jul 28, 2022

View reviewed changes

bkpr: cleanup csv_safe_str

4522951

rustyrussell merged commit 6e9af1e into ElementsProject:master Jul 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a `bookkeeper` plugin #5071

Add a `bookkeeper` plugin #5071

niftynei commented Mar 4, 2022 •

edited

Loading

rustyrussell commented Mar 5, 2022

cdecker left a comment

cdecker Mar 9, 2022

niftynei Mar 10, 2022

ZmnSCPxj Apr 25, 2022

niftynei Apr 26, 2022

ZmnSCPxj Apr 26, 2022 •

edited

Loading

cdecker Mar 9, 2022

niftynei Mar 10, 2022

cdecker Mar 10, 2022

niftynei Mar 11, 2022

cdecker Mar 10, 2022

cdecker Mar 10, 2022

cdecker Mar 10, 2022

niftynei Mar 12, 2022

niftynei commented Mar 12, 2022

michaelfolkson commented Mar 17, 2022

rustyrussell commented Mar 24, 2022

bertmiller commented Mar 26, 2022

rustyrussell commented Mar 27, 2022

rustyrussell left a comment

rustyrussell Jul 17, 2022

niftynei Jul 23, 2022

rustyrussell commented Jul 19, 2022

niftynei commented Jul 27, 2022

rustyrussell Jul 27, 2022

rustyrussell left a comment

rustyrussell commented Jul 28, 2022

Add a bookkeeper plugin #5071

Add a bookkeeper plugin #5071

Conversation

niftynei commented Mar 4, 2022 • edited Loading

rustyrussell commented Mar 5, 2022

cdecker left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ZmnSCPxj Apr 26, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

niftynei commented Mar 12, 2022

michaelfolkson commented Mar 17, 2022

rustyrussell commented Mar 24, 2022

bertmiller commented Mar 26, 2022

rustyrussell commented Mar 27, 2022

rustyrussell left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rustyrussell commented Jul 19, 2022

niftynei commented Jul 27, 2022

Choose a reason for hiding this comment

rustyrussell left a comment

Choose a reason for hiding this comment

rustyrussell commented Jul 28, 2022

Add a `bookkeeper` plugin #5071

Add a `bookkeeper` plugin #5071

niftynei commented Mar 4, 2022 •

edited

Loading

ZmnSCPxj Apr 26, 2022 •

edited

Loading