Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitcoin/chainparams.c: Change signet BIP173 name to tbs. #4929

Merged
merged 1 commit into from
Nov 27, 2021

Conversation

ZmnSCPxj
Copy link
Contributor

Fixes: #4924

ChangeLog-Changed: signet addresses and invoices now use tbs instead of tb.

Fixes: ElementsProject#4924

ChangeLog-Changed: `signet` addresses and invoices now use `tbs` instead of `tb`.
@ZmnSCPxj
Copy link
Contributor Author

This changes onchain bech32 addresses too. I could not find anything on the Internet about the "standard" bech32 address for signet, unfortunately. If the signet onchain addresses must still be tb while Lightning invoices are tbs, that is going to be a larger effort to change.

Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment

@cdecker
Copy link
Member

cdecker commented Nov 27, 2021

Well, seems we lost the battle to keep the prefixes in sync with bitcoin, which explicitly chose to reuse the tb prefix and the collision.

ACK 3cbe624

@cdecker cdecker merged commit a642d9f into ElementsProject:master Nov 27, 2021
@andrewtoth
Copy link
Contributor

andrewtoth commented Nov 28, 2021

err... not sure this should have been merged. Signet is unusable now on master. No signet faucet or wallet will recognize tbs, so unless you already had signet coins in the wallet already you can't use signet :/.

Edit - actually you can still use it with newaddr p2sh-segwit. For sending out you need an intermediate wallet that can generate p2sh-wrapped or legacy addresses if you can't get a non-bech32 address from the recipient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use lntbs for invoices on signet
4 participants