paystatus: remove doubled amount_msat.

[rustyrussell]

It's always been there:

{
   "pay": [
      {
         "bolt11": "...",
         "amount_msat": "1000msat",
         "amount_msat": "1000msat",
         "destination": "03...",
         "attempts": [
            {
               "strategy": "Initial attempt",
               "start_time": "2021-11-06T04:20:20.135Z",
               "age_in_seconds": 229032,
               "end_time": "2021-11-06T04:20:27.792Z",
               "state": "completed",
               "success": {
                  "id": 31994,
                  "payment_preimage": "..."
               }
            }
         ]
      }
   ]
}

Reported-by: denis2342 on IRC
Changelog-Fixed: JSON-RPC: paystatus entries no longer have two identical amount_msat entries.
Signed-off-by: Rusty Russell rusty@rustcorp.com.au

[vincenzopalazzo]

ack 105b096

[denis2342]

my proposal would be to replace both these amount_msat lines with the following line:

json_add_amount_msat_compat(ret, p->amount, "msatoshi", "amount_msat");

This generates two fields, one as string and one as integer, both msat.

[rustyrussell]

my proposal would be to replace both these amount_msat lines with the following line:

json_add_amount_msat_compat(ret, p->amount, "msatoshi", "amount_msat");

This generates two fields, one as string and one as integer, both msat.

The "msatoshi" fields are being slowly deprecated, though. The intention is that all amounts are explicitly "msat" (we had errors early on when amounts were specified differently in different places).

[denis2342]

my proposal would be to replace both these amount_msat lines with the following line:
json_add_amount_msat_compat(ret, p->amount, "msatoshi", "amount_msat");
This generates two fields, one as string and one as integer, both msat.

The "msatoshi" fields are being slowly deprecated, though. The intention is that all amounts are explicitly "msat" (we had errors early on when amounts were specified differently in different places).

So no integer field is wanted?

[ZmnSCPxj]

So no integer field is wanted?

Correct, the intent is to always use a string with an explicit unit.

[rustyrussell]

Trivial rebase on master.

Ack 9fbcc16