Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regtest fee control #4629

Merged
merged 3 commits into from
Jul 8, 2021
Merged

Regtest fee control #4629

merged 3 commits into from
Jul 8, 2021

Commits on Jul 8, 2021

  1. channeld: don't ever use 0 as a feerate. 

    This has been reported several times on regtest, most recently by Gijs
van Dam.  It turns out approx_max_feerate() was returning 0 in some
corner cases: we should *not* be using that value (as shown, it's
overly conservative) except as a ceiling on fee *increases*.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Fixed: Protocol: don't ever send 0 fee_updates (regtest bug).
    @rustyrussell
    rustyrussell committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    d612f62 View commit details
    Browse the repository at this point in the history

  2. lightningd: add force-feerates option. 

    Useful for regtest and testnet.  Sure, you shouldn't use this on mainnet,
but I haven't restricted it because our users are usually pretty clever.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Fixes: ElementsProject#1806
Changelog-Added: config: `force_feerates` option to allow overriding feerate estimates (mainly for regtest).
    @rustyrussell
    rustyrussell committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    5e3577e View commit details
    Browse the repository at this point in the history

  3. lightningd: don't complain about unable to estimate fees if not mainnet. 

    'force-feerates' already bypasses this logic, but we should still suppres

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    @rustyrussell
    rustyrussell committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    e55363b View commit details
    Browse the repository at this point in the history