Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS build fixes #4613

Merged
merged 2 commits into from
Jun 25, 2021
Merged

Conversation

nalinbhardwaj
Copy link
Contributor

Fixes #3203 and another issue I was seeing on my local build.

Changelog-Fixed: Fixes `make` with `--enable-developer` option on macOS.
Changelog-Fixed: Fixes `make full-check` errors on macOS
Copy link
Contributor

@rustyrussell rustyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I missed that we call update-mocks now to test that our mocks work.

I'm not sure what was wrong with the previous version, but this certainly works...

@rustyrussell
Copy link
Contributor

Ack c893ed6

@rustyrussell rustyrussell merged commit 0fccfc0 into ElementsProject:master Jun 25, 2021
@nalinbhardwaj nalinbhardwaj deleted the macos-build-fix branch June 25, 2021 01:09
@nalinbhardwaj
Copy link
Contributor Author

Ah, I missed that we call update-mocks now to test that our mocks work.

I'm not sure what was wrong with the previous version, but this certainly works...

Yeah, I'm not too sure what was broken either lol, my understanding was that case )) within set ( doesn't work in bash 3 nicely, but I've mostly just found this version with brute-forcing possibilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build fail with macos
2 participants