plugin: rescan restarts plugin on update #4609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-schmoock
force-pushed
the
feat/plugin_restart_on_update
branch
2 times, most recently
from
d89b1dd
to
d40abca
Compare
This comment has been minimized.
This comment has been minimized.
m-schmoock
force-pushed
the
feat/plugin_restart_on_update
branch
from
d40abca
to
0cb7b95
Compare
|
Just a test flake on tests/test_misc.py::test_funding_reorg_private |
m-schmoock
force-pushed
the
feat/plugin_restart_on_update
branch
2 times, most recently
from
0d441bd
to
13af6ae
Compare
This adds a `u32 checksum` field to the plugin struct that is used to identify if a plugin is outdated and needs to be restarted on `rescan`. Note: Only affects non-important plugins. Changelog-Added: Plugin: Restart plugin on `rescan` when binary was changed.
m-schmoock
force-pushed
the
feat/plugin_restart_on_update
branch
from
13af6ae
to
bdcf254
Compare
m-schmoock
force-pushed
the
feat/plugin_restart_on_update
branch
2 times, most recently
from
eaafd6e
to
657518b
Compare
m-schmoock
force-pushed
the
feat/plugin_restart_on_update
branch
from
657518b
to
1909b1f
Compare
|
Okay, same unrelated testflake. Other than that: done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
u32 checksumfield to the plugin struct that is usedto identify if a plugin is outdated and needs to be restarted on
rescan.Useful for developing and debugging plugins.
Note: only affects non-important plugins.
Changelog-Added: Plugin: Restarts a plugin on
rescanwhen its binary was changed.