Fix htlc error causing connclose #4550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/fix-htlc-error-connclose
branch
from
4b109ad to
b06afa3
Compare
|
ACK b06afa3 |
…nect bug. We set the timeout on first HTLC, but didn't clear it if that HTLC failed. It's saner to have a per-HTLC timeout (since that's what it is!) and also our timer infra is specially coded to scale approximately infinitely so trying to optimize this is vastly premature. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Fixed: Protocol: We would sometimes gratuitously disconnect 30 seconds after an HTLC failed.
|
Sigh. "Never change log messages". Trivial fix pushed for test. |
rustyrussell
force-pushed
the
guilt/fix-htlc-error-connclose
branch
from
b06afa3 to
de3fe42
Compare
|
Ack de3fe42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a side-effect, this fixes our MPP flake :)No, it does not.