Onion v2 deprecation #4549
Merged
Onion v2 deprecation #4549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darosior
force-pushed
the
onionv2_deprecation
branch
2 times, most recently
from
aff0c6a to
293a7f8
Compare
kristapsk
approved these changes
May 20, 2021
|
Second commit simply needs: |
darosior
force-pushed
the
onionv2_deprecation
branch
from
293a7f8 to
d9434ea
Compare
|
Done, and also updated the doc. |
rustyrussell
approved these changes
May 23, 2021
rustyrussell
force-pushed
the
onionv2_deprecation
branch
from
d9434ea to
e26603f
Compare
It really affected readability. Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Tor v2 hidden services have been deprecated for a while: https://blog.torproject.org/v2-deprecation-timeline . This prevents user from being able to set them in the configuration and to connect to them while still letting us be able to parse them for gossip. Changelog-Deprecated: lightningd: v2 Tor addresses. Use v3. See https://blog.torproject.org/v2-deprecation-timeline. Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Changelog-Deprecated: Changelog-Deprecated: lightningd: `enable-autotor-v2-mode` option. Use v3. See https://blog.torproject.org/v2-deprecation-timeline. Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
The doc is really confusing and would probably need a refactor, i did my best to remove references to v2 services without losing any meaning... Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
rustyrussell
force-pushed
the
onionv2_deprecation
branch
from
e26603f to
8658ba0
Compare
|
YA trivial rebase for conflicts on generated files Ack 8658ba0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents user from setting or connecting to v2 hidden services. This is behind
deprecated_apisbut since they are going to break in a month and a half on the Tor backend we should probably break before?I still need to update the doc and i wonder if we shoudl do anything about the
node_announcement.