createonion to accept an optional custom onion_size
#4519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
approved these changes
May 12, 2021
fiatjaf
force-pushed
the
custom-onion-sizes
branch
from
4971fd9
to
2cf2a32
Compare
|
Addressed your two comments. Please feel free to tweak other things if necessary! |
rustyrussell
approved these changes
May 12, 2021
|
@cdecker Wanted to write some tests to make sure this works as expected... |
|
Got bored waiting, added test. (It passed :) |
|
Nice. Next week we'll need a |
rustyrussell
force-pushed
the
custom-onion-sizes
branch
from
e9c8bb7
to
d4a2b27
Compare
|
Trivial rebase on master with CI fixes. Twice. Ack 9f9432d |
Changelog-Added: `createonion` RPC command now accepts an optional `onion_size`.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
custom-onion-sizes
branch
from
d4a2b27
to
9f9432d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to make a trampoline routing plugin and I'm hoping this very small change will be enough to allow me to make the custom trampoline onions to be built without me having to reimplement onion-making functions from scratch.