common: Check chain hash in gossip_timestamp_filter #4514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalinbhardwaj
force-pushed
the
chain_hash
branch
2 times, most recently
from
87a9e76
to
1b69e01
Compare
nalinbhardwaj
force-pushed
the
chain_hash
branch
2 times, most recently
from
5f6422e
to
177d3f3
Compare
rustyrussell
approved these changes
May 12, 2021
rustyrussell
force-pushed
the
chain_hash
branch
2 times, most recently
from
6158cde
to
fd2ea1b
Compare
|
Pushed trivial rebase due to textual conflicts with updated master. Ack fd2ea1b |
|
@rustyrussell thanks for the rebase. Seems like there's a few valgrind CI failures, but I'm assuming those are just flaky tests unrelated to my change. Let me know if not. |
|
Another rebase, hopefully fixes CI flakes. Ack ddfea7e |
Changelog-Fixed: Validate chain hash for gossip_timestamp_filter messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes in code
FIXMEfor checking chain hash in gossip_timestamp_filter messages. Updates tests to follow that as well.