subd version messages #4471
Merged
subd version messages #4471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For this patch we simply abort if it's wrong. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
For channeld, we move status_setup_sync() to a more obvious place. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/subd-versions
branch
from
d0d1246
to
fba8ac3
Compare
You still shouldn't do this (you could get some transient failures), but at least you have a decent chance if you reinstall over a running daemon, instead of getting confusing internal errors if message formats have changed. Changelog-Added: lightningd: we now try to restart if subdaemons are upgraded underneath us. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Fixes: ElementsProject#4346
This was always a theoretical race, but with the next change we actually hit it under valgrind. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This avoids subdaemons complaining about malformed messages from us, or doing the completely wrong thing, if they are really the wrong version. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/subd-versions
branch
from
fba8ac3
to
92131a0
Compare
cdecker
approved these changes
Apr 21, 2021
There was a problem hiding this comment.
Just a minor question about the ordering in channeld where we seem to happily process the channeld_init message before we send the version, which seems to contradict our intended goal.
Re-reading I see that it was me not seeing it the correct way around: this corrects the recv-then-init-subd logic we used before.
Also the exec logic is scary, but I can't see how it could fail.
ACK 92131a0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This catches the "oops, per-peer daemons have been upgraded underneath me!" problem; it still logs a BROKEN message, but it tried to re-exec itself.
We still have the version check at startup, so we don't infinite loop if we have a half-installed setup somehow.