Regtest feerate setting #4405
Merged
Regtest feerate setting #4405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
reviewed
Mar 1, 2021
plugins/bcli.c
Outdated
| @@ -994,6 +1015,10 @@ int main(int argc, char *argv[]) | |||
| " closed more often due to fee fluctuations," | |||
| " large values may result in large fees.", | |||
| u32_option, &bitcoind->max_fee_multiplier), | |||
| plugin_option("dev-no-fake-fees", | |||
| "bool", | |||
| "Supress fee faking for regtst", | |||
There was a problem hiding this comment.
Suggested change
| "Supress fee faking for regtst", | |
| "Supress fee faking for regtest", |
There was a problem hiding this comment.
There's also two pp in suppress :(
cdecker
approved these changes
Mar 1, 2021
Saves a great deal of confusion for regtest users. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Changed: JSON-RPC: If bitcoind won't give a fee estimate in regtest, use minimum.
We probably want to notify everyone immediately, rather than waiting for the first change. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…hment. They need to specify fees to get a channel before this, but it's possible. The test revealed no surprises (other than the last change). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
regtest-feerate-floor
branch
from
54d2795 to
6ebbacf
Compare
|
Ack 6ebbacf Spelling only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a dev knob to disable it for testing, but this is what everyone actually wants when using regtest, AFAICT.
During a recent demo I had one regtest peer send out an update_fee with a 0 rate. To my consternation, I have been unable to reproduce this. Is bitcoind giving wild fee estimates in some regtest setups?