feat: chain hook custommsg #4358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
approved these changes
Jan 29, 2021
Changelog-Changed: custommsg hook is now chainable
The current test was not checking for the output of the first plugin in the chain.
rustyrussell
force-pushed
the
feat/chain_hook_custommsg
branch
from
eca5619
to
0da15d5
Compare
|
Ack 0da15d5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will also make the
custommsghook chainable.Adds: Feature, documentation and tests.
Note: I made the hooks response
{'result': 'continue'}mandatory since this is cleaner for a chained hook.