json-rpc: Add support for querying by hash or bolt11 to listinvoices
#4312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
approved these changes
Jan 6, 2021
There was a problem hiding this comment.
Ack 7f128b1
Only one minor thing: maybe rename 'bolt11' to 'invstring', as suggested by the offers branch? It's going to be an anachronism one day.
cdecker
force-pushed
the
invoice-by-hash
branch
from
7f128b1
to
23ab13a
Compare
|
Re-applying Rusty's ACK after renaming bolt11 to invstring. ACK 4921610 |
A user reported that it is sometimes cumbersome to search an invoice based on the payment hash or the bolt11 string in the full list, which may be required when we don't have the label available. This adds support for querying / filtering based on the `payment_hash` or `bolt11` string. Changelog-Added: JSON-RPC: `listinvoices` can now query for an invoice matching a `payment_hash` or a `bolt11` string, in addition to `label`
We now have some more logic in the query, so let's test it exhaustively.
cdecker
force-pushed
the
invoice-by-hash
branch
from
23ab13a
to
4921610
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user reported that it is sometimes cumbersome to search an invoice
based on the payment hash or the bolt11 string in the full list, which
may be required when we don't have the label available.
This adds support for querying / filtering based on the
payment_hashor
bolt11string.