pyln: Add command notifications support #4311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
force-pushed
the
pyln-command-notify
branch
from
59d3a5c
to
d12b5bf
Compare
rustyrussell
reviewed
Jan 6, 2021
| @@ -141,6 +141,24 @@ def set_exception(self, exc: Union[Exception, RpcException]) -> None: | |||
| def _write_result(self, result: dict) -> None: | |||
| self.plugin._write_locked(result) | |||
|
|
|||
| def notify(self, message: str, level='DEBUG') -> None: | |||
| """Send a notification to the caller. | |||
There was a problem hiding this comment.
We already have this? It's split into the two kinds of notifications we have currently defined though: notify_message and notify_progress.
There was a problem hiding this comment.
Oh, I didn't see that it's in the Plugin not the Request, that's a really weird place for it, if we require access to the request anyway. I'll change Plugin.notify_message to become a wrapper of Request.notify and move that code there instead.
There was a problem hiding this comment.
Ah, good point. Pretty sure this API is unused, so just move it.
Changelog-Added: pyln-client: Plugin methods can now report progress or status via the `Request.notify` function
Changelog-Added: pyln-client: Added support for command notifications to LightningRpc via the `notify` context-manager.
cdecker
force-pushed
the
pyln-command-notify
branch
from
d12b5bf
to
81a73b5
Compare
|
Ack 81a73b5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds command notification support to both the RPC client library as
well as the plugin library. This allows RPC clients to register a
notification callback that gets called for each notification, and
allows plugin methods to report status or progress using the
Request.notifymethod.