Added spent option to listfunds #4296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On some distros you can install a |
ZmnSCPxj
approved these changes
Dec 22, 2020
|
@ZmnSCPxj I'm not a C or Python coder for the most part so thanks for the hint, helps me navigate these unknown waters. I managed to add the |
|
ACK 1e67a90 |
cdecker
force-pushed
the
listfunds_spent
branch
from
3dabeb8 to
1e67a90
Compare
Changelog-Added: JSON-RPC: The `listfunds` method now includes spent outputs if the `spent` parameter is set to true.
cdecker
force-pushed
the
listfunds_spent
branch
from
1e67a90 to
f31a27e
Compare
|
ACK f31a27e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
spentoption (a boolean) tolistfundswhich adds spent outputs to theoutputsif set to true.I didn't see any
test_listfundsPython test so I thought I'd write one but then I couldn't figure out how to actually run these Python tests after readingHACKING.md:)blackbox tests - These tests setup a mini-regtest environment and test
lightningd as a whole. They can be run individually:
PYTHONPATH=contrib/pylightning:contrib/pyln-client:contrib/pyln-testing:contrib/pyln-proto py.test -v tests/What's
py.test?I checked
travis.ymlto see how it does that and it sets up bitcoind and elements and it's Linux specific but I'm using a Mac. If anyone knows how to runtests/test_misc.pyon a Mac and could share this info with me I'd appreciate it.Fixes #4291