setchannelfee: fix crash when channel is not in valid state. #4282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can't fail a cmd when you've already started streaming a successful response: lightningd: ccan/ccan/json_out/json_out.c:343: json_out_finished: Assertion `tal_count(jout->wrapping) == 0' failed. lightningd: FATAL SIGNAL 6 (version v0.9.2-119-gf7cdf1d) 0x1847d1 send_backtrace common/daemon.c:38 0x184877 crashdump common/daemon.c:51 0x5bda03f ??? ???:0 0x5bd9fb7 ??? ???:0 0x5bdb920 ??? ???:0 0x5bcb489 ??? ???:0 0x5bcb501 ??? ???:0 0x1e07a8 json_out_finished ccan/ccan/json_out/json_out.c:343 0x18db0a json_stream_double_cr common/json_stream.c:95 0x18dbf3 json_stream_close common/json_stream.c:117 0x12fd98 command_raw_complete lightningd/jsonrpc.c:459 0x12fec9 command_failed lightningd/jsonrpc.c:488 0x12ffb9 command_fail lightningd/jsonrpc.c:503 0x14dc20 json_setchannelfee lightningd/peer_control.c:2052 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Fixed: JSONRPC: `setchannelfee` would fail an assertion if channel wasn't in normal state.
m-schmoock
approved these changes
Dec 17, 2020
There was a problem hiding this comment.
ACK 93e2b19
That is correct.
I wrote a testcase that checks for this. Feel free to add it to tests/test_pay.py.
It also checks that channel lookup by channel_id is possible, which was uncovered before.
def test_setchannelfee_closed(node_factory, bitcoind):
l1, l2 = node_factory.line_graph(2)
# We use the `channel_id` (not scid) by intention
# to also test channel lookup using `channel_id`.
cid = l1.get_channel_id(l2)
l2.stop()
l1.rpc.close(cid, 1)
with pytest.raises(RpcError, match="Channel is in state AWAITING_UNILATERAL"):
l1.rpc.setchannelfee(cid, 12, 34)
darosior
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can't fail a cmd when you've already started streaming
a successful response:
lightningd: ccan/ccan/json_out/json_out.c:343: json_out_finished: Assertion `tal_count(jout->wrapping) == 0' failed.
lightningd: FATAL SIGNAL 6 (version v0.9.2-119-gf7cdf1d)
0x1847d1 send_backtrace
common/daemon.c:38
0x184877 crashdump
common/daemon.c:51
0x5bda03f ???
???:0
0x5bd9fb7 ???
???:0
0x5bdb920 ???
???:0
0x5bcb489 ???
???:0
0x5bcb501 ???
???:0
0x1e07a8 json_out_finished
ccan/ccan/json_out/json_out.c:343
0x18db0a json_stream_double_cr
common/json_stream.c:95
0x18dbf3 json_stream_close
common/json_stream.c:117
0x12fd98 command_raw_complete
lightningd/jsonrpc.c:459
0x12fec9 command_failed
lightningd/jsonrpc.c:488
0x12ffb9 command_fail
lightningd/jsonrpc.c:503
0x14dc20 json_setchannelfee
lightningd/peer_control.c:2052
Signed-off-by: Rusty Russell rusty@rustcorp.com.au
Changelog-Fixed: JSONRPC:
setchannelfeewould fail an assertion if channel wasn't in normal state.